Replace github.com/pkg/errors dependency with native error wrapping

[saschagrunert]

The PR #2478 got reverted because it caused troubles with the error wrapping conversion.

We should still do that, because the package github.com/pkg/errors is now in maintenance mode due to the golang native error wrapping. The goal is to do that on a package-by-package basis, where everyone is welcome to contribute.

The basic conversion rules:

• use the errors import in favor of github.com/pkg/errors
• convert errors.Errorf to fmt.Errorf
• convert errors.Wrap(err, "…") to fmt.Errorf("…: %w", err) and check that err != nil before
• convert errors.Wrapf(err, "… %s: %s", foo, bar) to fmt.Errorf("… %s: %s: %w", foo, bar err) and check that err != nil before

Packages to be converted:

• cmd/krel (@Debanitrkl): changed to golang native error wrapping #2571
• pkg/release (@Priyankasaggu11929): pkg/release: replace github.com/pkg/errors dependency with native error wrapping #2566
• cmd/schedule-builder (@Priyankasaggu11929): cmd/schedule-builder: replace github.com/pkg/errors dependency with native error wrapping #2557
• cmd/ci-reporter (@Debanitrkl): Replaced pkg/errors dependency #2553
• pkg/announce (@jasonbraganza): pkg/announce: replace github.com/pkg/errors dependency with native error wrapping #2564
• pkg/notes (@DiptoChakrabarty): replace github/.com/pkg/errors dependency notes package #2568
• cmd/kubepkg (@Debanitrkl): Changed to golang native error wrapping #2554
• cmd/publish-release (@Priyankasaggu11929): cmd/publish-release: replace github.com/pkg/errors dependency with native error wrapping #2556
• cmd/release-notes (@DiptoChakrabarty): replace github.com/pkg/errors dependency in release notes package #2555
• pkg/binary (@jasonbraganza): pkg/binary: replace github.com/pkg/errors dependency with native error wrapping #2565
• pkg/build (@Priyankasaggu11929): pkg/build: replace github.com/pkg/errors dependency with native error wrapping #2558
• pkg/changelog (@ArkaSaha30): Replace pkg/errors dependency #2552
• pkg/cve (@ArkaSaha30): Replace pkg/errors dependency #2552
• pkg/fastforward (@ArkaSaha30): Replace pkg/errors dependency #2552
• pkg/gcp (@ArkaSaha30): Replace pkg/errors dependency #2552
• pkg/kubecross (@Priyankasaggu11929): pkg/kubecross: replace github.com/pkg/errors dependency with native error wrapping #2559
• pkg/kubepkg (@Priyankasaggu11929): pkg/kubepkg: replace github.com/pkg/errors dependency with native error wrapping #2560
• pkg/mail (@pradeepnnv): Remove github.errors usage #2551
• pkg/testgrid (@Priyankasaggu11929): pkg/testgrid: replace github.com/pkg/errors dependency with native error wrapping #2561

[palnabarun]

Anyone willing to take up one of the above packages, please comment here with the package that you will refactor before starting to work on it.

[Debanitrkl]

I can take up the ci-reporter, krel and kubepkg

[palnabarun]

/assign

(for tracking)

[Priyankasaggu11929]

I can take:

cmd/publish-release
cmd/schedule-builder
pkg/build
pkg/kubecross
pkg/kubepkg
pkg/release
pkg/testgrid

[ArkaSaha30]

I will take up:

pkg/changelog
pkg/cve
pkg/fastforward
pkg/gcp

[puerco]

Folks, as @saschagrunert said in the third case above, pay attention to the following construct we sometimes have in the code. It was the one that broke krel in the reverted pr:

// This would return nil or an error, so simple search and replace will not work:
return errors.Wrap(err, "XXXXX")

// It should instead be replaced with something like this:
if err != nil {
   return fmt.Errorf("XXXXX: %w")
}
return nil

[pradeepnnv]

I'll work on pkg/mail.

[DiptoChakrabarty]

I can work on cmd/release-notes and pkg/notes

[jasonbraganza]

I will take on pkg/announce and pkg/binary

[Priyankasaggu11929]

/reopen

[k8s-ci-robot]

@Priyankasaggu11929: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saschagrunert]

Thank you all! We're almost done with this, just found one missing place in #2581 🙏