Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme for cronjob collector #411

Merged
merged 2 commits into from
Apr 4, 2018
Merged

update readme for cronjob collector #411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa0c01
update readme for cronjob collector
r0fls Apr 3, 2018
6964974
remove cronjob alpha statement
r0fls Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,7 @@ additional metrics!
> * kube_node_status_capacity_nvidia_gpu_cards
> * kube_node_status_allocatable_nvidia_gpu_cards
>
> are in alpha stage and will be deprecated when the kubernetes gpu support is final in 1.9 version.
>
> **collectors**
> * v2alpha1/cronjob
>
> If users want to enable this feature when kubernetes version larger than 1.7,
> It must be configured, with the following parameter setting for apiserver.
> `--runtime-config=batch/v2alpha1=true`
> are in alpha stage and will be deprecated when the kubernetes accelerator feature support is deprecated in version v1.11.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes accelerator feature support is deprecated in version v1.11.

Kubernetes accelerator support is already deprecated in 1.10. The PR to completely remove it is merged in master, so it will be completely removed in 1.11.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindprince Thanks for the more accurate deprecation procudure about Kubernetes accelerator. Will fire another PR to update this info.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindprince FRI #417

>
> Any collectors and metrics based on alpha Kubernetes APIs are excluded from any stability guarantee,
> which may be changed at any given release.
Expand Down