update readme for cronjob collector #411
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
README.md
Outdated
| > If users want to enable this feature in kubernetes version less than 1.8, | ||
| > it must be configured with the following parameter setting for apiserver: | ||
| > `--runtime-config=batch/v2alpha1=true`. For cluster versions >= 1.8, cronjobs | ||
| > are enabled by default in batch/v2alpha1 |
There was a problem hiding this comment.
I think we should just remove this statement all together, as kube-state-metrics only supports using the v1beta1 API.
There was a problem hiding this comment.
Sounds good, I left the following lines though: https://github.com/kubernetes/kube-state-metrics/pull/411/files#diff-04c6e90faac2675aa89e2176d2eec7d8R100
Since it seems they still apply to the GPU metrics.
There was a problem hiding this comment.
According to Kubernetes 1.10 release note:
The alpha Accelerators feature gate is deprecated and will be removed in v1.11. Please use device plugins (kubernetes/enhancements#368) instead. They can be enabled using the DevicePlugins feature gate. (#57384, @mindprince)
gpu support for kube-state-metrics will exist at least until Kubernetes 1.11. It's ok to keep gpu related statement here for now.
@r0fls BTW, could you please update the statement about the deprecation for gpu since it is not accurate for now:
are in alpha stage and will be deprecated when the kubernetes gpu support is final in 1.9 version. -> are in alpha stage and will be deprecated when the kubernetes accelerator feature support is deprecated in v1.11 version.
There was a problem hiding this comment.
lgtm.
Waiting for an additional review from @brancz
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, r0fls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| > If users want to enable this feature when kubernetes version larger than 1.7, | ||
| > It must be configured, with the following parameter setting for apiserver. | ||
| > `--runtime-config=batch/v2alpha1=true` | ||
| > are in alpha stage and will be deprecated when the kubernetes accelerator feature support is deprecated in version v1.11. |
There was a problem hiding this comment.
kubernetes accelerator feature support is deprecated in version v1.11.
Kubernetes accelerator support is already deprecated in 1.10. The PR to completely remove it is merged in master, so it will be completely removed in 1.11.
There was a problem hiding this comment.
@mindprince Thanks for the more accurate deprecation procudure about Kubernetes accelerator. Will fire another PR to update this info.
update readme for cronjob collector
fix #409