Use protobuf/jsonpb instead of golang json in some cases
#178
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -0,0 +1,829 @@ | |||
| // Go support for Protocol Buffers - Google's data interchange format | |||
There was a problem hiding this comment.
This is a vendor update, does vendor.conf need update?
There was a problem hiding this comment.
Only update jsonpb here, I think we dont need update vendor.conf unless other model depend on the new version of protobuf. :)
|
@miaoyq How do we handle extra information then? |
|
@Random-Liu We could handle extra info via "outputStatusInfo" |
|
@Random-Liu "protobufObjectToJSON(status)" handles resp.Status, and "json.Marshal" handles resp.Info |
LGTM. @Random-Liu do you have any other concerns? |
@Random-Liu @feiskyer Updated, also related to #166. |
cmd/crictl/util.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: unnecessary empty line.
|
@miaoyq For some other commands, we also support yaml/json output. We should also use jsonpb for those cases. I'm fine with doing that in another PR, but please make sure the issue is open. |
Will do. |
Signed-off-by: Yanqiang Miao <miao.yanqiang@zte.com.cn>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
For #154
/cc @Random-Liu
Signed-off-by: Yanqiang Miao miao.yanqiang@zte.com.cn