Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use github.com/golang/protobuf/jsonpb instead of golang json package. #154

Closed
Random-Liu opened this issue Oct 11, 2017 · 1 comment
Closed

We should use github.com/golang/protobuf/jsonpb instead of golang json package. #154

Random-Liu opened this issue Oct 11, 2017 · 1 comment

Comments

@Random-Liu
Copy link
Contributor

Currently if a container exit with exit code 0, when we do crictl inspect, there won't be exit code field, because that is omitted https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/v1alpha1/runtime/api.pb.go#L2119.

We should use github.com/golang/protobuf/jsonpb, so that we could configure EmitDefaults to fix this.
@miaoyq miaoyq mentioned this issue Nov 4, 2017
Merged
@Random-Liu
Copy link
Contributor Author

I think this has been fixed. Close this one.

@miaoyq miaoyq mentioned this issue Dec 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Random-Liu