-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow backport for experimental features #8293
🌱 Allow backport for experimental features #8293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - I think the two maintainers rule will help to keep this to the minimum necessary changes.
/lgtm
LGTM label has been added. Git tree hash: 8840ba6ea3576b749cc0344a9c6c33df87ce31a4
|
/lgtm Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
squash commits?
discussed this today in the community meeting, would be nice to start practicing this for our next release. no rush on getting this merged though. if no objections by next friday, we will merge this. |
Not super important but I assume this means next week Friday? (cc @killianmuldoon @fabriziopandini given recent discussion around this phrase 😂) |
0a40194
to
6f31397
Compare
The lazy consensus deadline expired |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: new pull request created: #8441 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area release |
/area documentation |
What this PR does / why we need it:
Proposing a small amendment to backport policy in order to allow a little bit of more flexibility for experimental features