Skip to content

Commit

Permalink
requiring lgtm from two maintainers
Browse files Browse the repository at this point in the history
  • Loading branch information
fabriziopandini committed Mar 22, 2023
1 parent f4d2448 commit 0a40194
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ We generally allow backports of following changes only to the latest supported b
While we recommend to target following type of changes to the next minor release, CAPI maintainers will also consider
exceptions for backport of following changes only to the latest supported branch:
- Enhancements or additions to experimental Cluster API features, with the goal of allowing faster adoption and iteration;
Please note that stability of the branch will always be top priority while evaluating those PRs, and thus on top of checking
that the changes are not introducing any breaking change for either API or behavior, maintainers will evaluate if the impact of
those backport is limited and well-scoped e.g. by checking that those changes should not touch non-experimental code paths
like utils and/or apply other considerations depending on the specific PR.
Please note that stability of the branch will always be top priority while evaluating those PRs, and thus approval
requires /lgtm from at least two maintainers that, on top of checking that the backport is not introducing any breaking
change for either API or behavior, will evaluate if the impact of those backport is limited and well-scoped e.g.
by checking that those changes should not touch non-experimental code paths like utils and/or by applying other
considerations depending on the specific PR.

Like any other activity in the project, backporting a fix/change is a community-driven effort and requires that someone volunteers to own the task.
In most cases, the cherry-pick bot can (and should) be used to automate opening a cherry-pick PR.
Expand Down

0 comments on commit 0a40194

Please sign in to comment.