Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix TestServerSideApplyWithDefaulting flakes #10905

Merged
merged 2 commits into from
Jul 19, 2024
Merged

🐛 Fix TestServerSideApplyWithDefaulting flakes #10905

merged 2 commits into from
Jul 19, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR is an attempt to get rid of TestServerSideApplyWithDefaulting flakes.

The assumption is that the test case "no-op_if_neither_is_defaulted" is moving too quickly from creating the webhook and calling NewServerSidePatchHelper, which expect the web up to be already registered/recognized by the API server.

The fix introduces as wait loop after creating the web hook to make sure the webhook is up and running before moving on.

Which issue(s) this PR fixes:
Fixes #10902

/area clusterclass

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2024
@fabriziopandini fabriziopandini mentioned this pull request Jul 18, 2024
Closed
@fabriziopandini
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

2 similar comments
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

chrischdi
chrischdi reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@chrischdi
Copy link
Member

/lgtm cancel

see above comments :-)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@fabriziopandini fabriziopandini added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Jul 19, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

2 similar comments
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 19, 2024
@sbueringer
Copy link
Member

Thx! and nice idea with the dry-run @chrischdi !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59e3519eadd8c527089413dae0a36bc8e9b1d448

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@sbueringer sbueringer removed the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Jul 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 95e8d4b into kubernetes-sigs:main Jul 19, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 19, 2024
@fabriziopandini fabriziopandini deleted the fix-TestServerSideApplyWithDefaulting-flakes branch September 9, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

TestServerSideApplyWithDefaulting/no-op_if_neither_is_defaulted is flaky
4 participants
@fabriziopandini @k8s-ci-robot @chrischdi @sbueringer