Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestServerSideApplyWithDefaulting/no-op_if_neither_is_defaulted is flaky #10902

Closed
Sunnatillo opened this issue Jul 18, 2024 · 6 comments · Fixed by #10905
Closed

TestServerSideApplyWithDefaulting/no-op_if_neither_is_defaulted is flaky #10902

Sunnatillo opened this issue Jul 18, 2024 · 6 comments · Fixed by #10905
Assignees
@Sunnatillo
Labels
area/ci Issues or PRs related to ci kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Sunnatillo
Copy link
Contributor

Sunnatillo commented Jul 18, 2024 •
edited
Loading

Which jobs are failing?

periodic-cluster-api-test-mink8s-main
periodic-cluster-api-test-release-1-6
periodic-cluster-api-test-main
periodic-cluster-api-test-mink8s-release-1-6
periodic-cluster-api-test-mink8s-release-1-7

Which tests are failing?

TestServerSideApplyWithDefaulting/no-op_if_neither_is_defaulted is flaky

Since when has it been failing?

07/09

Testgrid link

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-test-mink8s-main/1813627869608284160

Reason for failure (if possible)

No response

Anything else we need to know?

No response

Label(s) to be applied

/kind flake
/area ci

/assign @Sunnatillo
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/ci Issues or PRs related to ci needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2024
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2024
@sbueringer
Copy link
Member

I think it's "just" flaky and not failing 100% of the time, correct?

@Sunnatillo
Copy link
Contributor Author

yes, I made the issue from wrong template

@Sunnatillo
Copy link
Contributor Author

/kind flake

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Jul 18, 2024
@sbueringer sbueringer removed the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 18, 2024
@fabriziopandini fabriziopandini added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 18, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Jul 18, 2024
@fabriziopandini fabriziopandini mentioned this issue Jul 18, 2024
Merged
@fabriziopandini
Copy link
Member

This is tricky to reproduce locally, but I have a theory about why ti might fail in CI and created #10905 to see if it solves the issue.

Note: the PR above also improve error message in case the same error happens again

@Sunnatillo
Copy link
Contributor Author

Thank you @fabriziopandini taking care of it. Indeed it was tricky to reproduce it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sunnatillo Sunnatillo

Labels
area/ci Issues or PRs related to ci kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix TestServerSideApplyWithDefaulting flakes fabriziopandini/cluster-api
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @Sunnatillo