Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRDs to include additional get information #260

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Update CRDs to include additional get information #260

merged 1 commit into from
Feb 27, 2020

Conversation

huffmanca
Copy link
Contributor

@huffmanca huffmanca commented Feb 25, 2020 •
edited by xing-yang
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Includes additional information for the get command for the VolumeSnapshot* CRDs.

Which issue(s) this PR fixes:
Fixes #247

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Prints additional details when using kubectl get on VolumeSnapshot, VolumeSnapshotContent, and VolumeSnapshotClass API objects.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @huffmanca. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2020
@huffmanca huffmanca mentioned this pull request Feb 25, 2020
Closed
@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2020
@xing-yang
Copy link
Collaborator

/assign @yuxiangqian

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2020
xing-yang
xing-yang reviewed Feb 27, 2020
View reviewed changes
Copy link
Collaborator

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more comments on the column descriptions. Other than that, this looks good.

config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml Outdated Show resolved Hide resolved
config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml Show resolved Hide resolved
@huffmanca
Copy link
Contributor Author

@xing-yang ,

The descriptions should now be updated.

@xing-yang
Copy link
Collaborator

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5b4d006 into kubernetes-csi:master Feb 27, 2020
@huffmanca huffmanca mentioned this pull request Feb 27, 2020
Merged
@huffmanca huffmanca mentioned this pull request Apr 17, 2020
Closed
6 tasks
@humblec humblec mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

@yuxiangqian yuxiangqian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print useful info in kubectl get <CRD>
4 participants
@huffmanca @k8s-ci-robot @xing-yang @yuxiangqian