Invalid api-conventions URL link

[c3y1huang]

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:
Original URL link is invalid.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: c3y1huang
To complete the pull request process, please assign xing-yang
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @c3y1huang. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

Those are generated automatically by running hack/update-crd.sh so we are not supposed to modify them manually.

[c3y1huang]

Reverted URL update for CRDs.

[xing-yang]

@yuxiangqian PTAL.

[xing-yang]

CI failed because you also have to update generated code after modifying types.go.

Take a look of the following issue. Generating code is getting complicated after we changed the package path for v2:
#239 (comment)

[c3y1huang]

CI failed because you also have to update generated code after modifying types.go.

Take a look of the following issue. Generating code is getting complicated after we changed the package path for v2:
#239 (comment)

Thanks @xing-yang , CI failed due to vendor changes. Don't know what I was thinking :-/. Revert to address.
PTAL.

[xing-yang]

Just noticed that this other PR (#256) which was submitted a few days earlier than this PR already contains changes in this PR. Let's put this PR on hold for now, wait until the other PR is merged, and then see if there're any additional things that need to be addressed.

[humblec]

@c3y1huang the PR changs intended here already got in via #260 , unless if some other changes are planned with this PR, I believe we could close this one.. Thanks! @xing-yang what do you think ?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[k8s-ci-robot]

@c3y1huang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.