-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kodadot-2195): pulse-chart for series and spotlight #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol stuff
hi @vikiival, I'm wondering if those new fields are cacheable? And if are, could you share some examples or best practices I could learn. Many thanks. |
nope we need to update the |
will drop example later today |
it's more complex than I previously thought. But what we can do now is either merge this because it's LGTM or extend the resolvers with additional resolver that can return Should be an easy hack |
I think we can merge this now. Haha, I kinda prefer the current one it's kind of neater, which also is suggested by the official doc. Besides, so, for fieldResolver, it is unable to cache, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise oki
hmm, nice~ By tomorrow I can work on the front-end code, excited. Besides, I saw the nft-gallery/issue#660, if anything you felt that I can help you out, please don't hesitate to reach me on Discord or at me on Github. |
Yup I need to release something asaP :) |
Progress