Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kodadot-2195): pulse-chart for series and spotlight #62

Merged
merged 8 commits into from
May 8, 2022

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented May 1, 2022

Progress

  • feat: series buy history
  • feat: spotlight sold history
  • feat: update cache for series and spotlight

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol stuff

src/server-extension/model/event.model.ts Outdated Show resolved Hide resolved
src/server-extension/resolvers/series.ts Show resolved Hide resolved
src/server-extension/query/event.ts Outdated Show resolved Hide resolved
@KngZhi
Copy link
Contributor Author

KngZhi commented May 5, 2022

hi @vikiival, I'm wondering if those new fields are cacheable? And if are, could you share some examples or best practices I could learn. Many thanks.

@KngZhi KngZhi changed the title WIP(demo): pulse-chart for series and spotlight feat(kodadot-2195): pulse-chart for series and spotlight May 5, 2022
@vikiival
Copy link
Member

vikiival commented May 5, 2022

those new fields are cacheable

nope we need to update the series entity and cache.ts

@vikiival
Copy link
Member

vikiival commented May 5, 2022

will drop example later today

@vikiival
Copy link
Member

vikiival commented May 6, 2022

it's more complex than I previously thought.
I already opened an issue #68

But what we can do now is either merge this because it's LGTM or extend the resolvers with additional resolver that can return HistoryEntity[] based on the array of ids you provide on frontend :).

Should be an easy hack

@KngZhi
Copy link
Contributor Author

KngZhi commented May 6, 2022

I think we can merge this now.

Haha, I kinda prefer the current one it's kind of neater, which also is suggested by the official doc.

Besides, so, for fieldResolver, it is unable to cache, right?

@vikiival
Copy link
Member

vikiival commented May 8, 2022

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise oki

@KngZhi
Copy link
Contributor Author

KngZhi commented May 8, 2022

hmm, nice~ By tomorrow I can work on the front-end code, excited.

Besides, I saw the nft-gallery/issue#660, if anything you felt that I can help you out, please don't hesitate to reach me on Discord or at me on Github.

@vikiival
Copy link
Member

vikiival commented May 8, 2022

Besides, I saw the kodadot/nft-gallery#660, if anything you felt that I can help you out, please don't hesitate to reach me on Discord or at me on Github.

Yup I need to release something asaP :)

@vikiival vikiival merged commit 0222006 into kodadot:main May 8, 2022
@vikiival vikiival linked an issue May 8, 2022 that may be closed by this pull request
@KngZhi KngZhi deleted the issue-58 branch May 8, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulse chart resolver
2 participants