feat(2195): mini-pulse-history component #2884

KngZhi · 2022-04-19T05:33:46Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR related Mini pulse history component #2195
<brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot

My fix has changed something on UI; a screenshot is best to understand changes for others.

kodabot · 2022-04-19T05:33:49Z

WARNING @KngZhi PR for issue #2195 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #2195

netlify · 2022-04-19T05:33:51Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`5100a2d`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62746b9454e0390008314f4a
😎 Deploy Preview	https://deploy-preview-2884--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

KngZhi · 2022-04-19T06:05:42Z

Hey @yangwao this is a demo page, do you prefer this UI for desktop and mobile.

Besides, I think we need to update the resolver to retrieve relevant data, but I'm kinda stuck with that, is there anyone I can resort to or communicate with.

yangwao · 2022-04-23T12:20:46Z

nice!

KngZhi · 2022-04-25T05:43:10Z

Brief Summary:

feat:

a mini-history component for the series and spotlight(EChart)
queries for historical data, and PLEASE correct me if there had any more efficient or clean way to do GraphQL. 😄 [1]

fix:

using computed data for the spotlight
[spotlight] fix pageSize problem
align-center for each column

refactor:

using computed data as the datasource for the spotlight

Following TODOs(for other PRs):

Since the EChart supports SVG format, which is more friendly to Mobile, I want to refactor other pages that use Chart.js
Clean useless code inside spotlight and series, besides, refactor some duplicate code.

vikiival

This should be done via rubick resolver

components/series/SeriesTable.vue

components/series/utils.ts

package.json

components/spotlight/SpotlightTable.vue

vikiival · 2022-04-26T09:35:33Z

Is it possible to specify the data you need?

I would rather write resolver for this kodadot/rubick#58

KngZhi · 2022-04-26T10:00:13Z

The data structure would be like this

{
  "Collection_id": {
    "2021-02-04": 2,
    "2022-02-05": 3
  }
}

The key is date that buy event happened and the value is how many times buy transactions happened.

I'm outside now, using phone, sorry with the format.

KngZhi · 2022-04-26T10:02:20Z

Besides, could you check kodadot/rubick#54

yangwao · 2022-05-05T12:34:49Z

pay 150 usd

yangwao · 2022-05-05T12:38:59Z

Wait, some graphs seem suspicious same, why is it like that?

Screen.Recording.2022-05-05.at.14.37.35.mov

yangwao · 2022-05-05T12:40:12Z

Looks like overlay bug

KngZhi · 2022-05-05T15:16:56Z

Wait, some graphs seem suspicious same, why is it like that?

Screen.Recording.2022-05-05.at.14.37.35.mov

hmm, seems some data duplicated. Will fix it right now.

KngZhi · 2022-05-06T00:27:56Z

@yangwao
https://vimeo.com/706753042/0a68a270a5

yangwao · 2022-05-06T07:37:53Z

@KngZhi you can directly upload videos to github input box to save you time like on this video :)

Screen.Recording.2022-05-06.at.09.37.25.mov

yangwao · 2022-05-06T07:39:17Z

pay 150 usd

yangwao · 2022-05-06T07:40:29Z

pay 150 usd

yangwao · 2022-05-06T07:42:03Z

Error completing request

lol what payout bot 👀

yangwao · 2022-05-06T07:42:13Z

pay 100 usd

KngZhi · 2022-05-06T07:43:15Z

@KngZhi you can directly upload videos to github input box to save you time like on this video :)

Screen.Recording.2022-05-06.at.09.37.25.mov

@yangwao oh, my, thanks, learned a new technique, hahaha 😄

Screen.Recording.2022-05-06.at.3.41.52.PM.mov

yangwao · 2022-05-06T07:43:51Z

pay 100 usd

yangwao · 2022-05-06T07:45:34Z

oh got it, your address has 47 chars when I matching only 46 hmm, got it

KngZhi · 2022-05-06T07:47:44Z

Okay.

yangwao · 2022-05-06T07:48:00Z

hey I've put in que and mentioned in #2941 so seems you have a different address than I wrote matching regexp.

Also, @KngZhi invite you for bounty help to figure out the right matching stuff for the KSM address than I'm using one in #2941 :)

I'll merge it so it's out there and can continue with resolver and retroactively repay, don't worry 🤞

vikiival · 2022-05-06T07:57:36Z

🚀

yangwao · 2022-05-06T09:39:16Z

pay 100 usd

yangwao · 2022-05-06T14:58:04Z

pay 100 usd

yangwao · 2022-05-06T14:58:11Z

😍 Perfect, I’ve sent the payout
💵 $100 @ 123.95 USD/KSM ~ 0.807 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x52329283d8a8ae1d8806f937f74f5260db1a9f3de2f23c94b82a90b1965db7da

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

feat: add mini-history demo

f53896a

KngZhi requested a review from a team as a code owner April 19, 2022 05:33

KngZhi requested review from prachi00 and removed request for a team April 19, 2022 05:33

KngZhi added 6 commits April 22, 2022 12:30

feat: fetch buy events from lastFourWeeks

87770f0

feat: min-history Component for series table

c87439a

refactor: using computed data

887337c

refactor: extract util function

3530273

refactor: deprecate usersWithIdentity

ae9dee4

fix: pageSize and init PER_PAGE

8e540fa

KngZhi added 3 commits April 24, 2022 16:12

feat: spotlight sold History

8bc5f3b

feat: refetch data when toggle Identity

0a498cd

feat: i18n support

d2c9fc5

KngZhi changed the title ~~WIP: mini-pulse-history component~~ [DONE] mini-pulse-history component Apr 25, 2022

KngZhi added 2 commits April 25, 2022 13:20

feat: add skeleton to series table

dfae818

fix: refresh when random

4833d4d

yangwao requested a review from vikiival April 25, 2022 10:15

vikiival requested changes Apr 26, 2022

View reviewed changes

vikiival mentioned this pull request Apr 26, 2022

Pulse chart resolver kodadot/rubick#58

Closed

KngZhi added 3 commits April 27, 2022 16:38

fix: resolve review request

67a2002

fix: byebye ECharts

727216a

feat: chartjs PulseChart

022f7b3

Merge branch 'main' into issue-2195

a14e6dc

Merge branch 'main' into issue-2195

d40b2b0

KngZhi added 2 commits May 5, 2022 23:20

fix: data duplicate and overlay

6a03636

trying to redeploy

54b892f

Merge branch 'main' into issue-2195

5100a2d

yangwao mentioned this pull request May 6, 2022

🧑‍🔧 check payout bot for not paid PRs #2941

Closed

yangwao enabled auto-merge May 6, 2022 07:53

yangwao disabled auto-merge May 6, 2022 07:54

yangwao merged commit 5835fdb into kodadot:main May 6, 2022

yangwao added the paid pull-request has been paid label May 6, 2022

KngZhi deleted the issue-2195 branch May 6, 2022 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(2195): mini-pulse-history component #2884

feat(2195): mini-pulse-history component #2884

KngZhi commented Apr 19, 2022 •

edited

Loading

kodabot commented Apr 19, 2022

netlify bot commented Apr 19, 2022 •

edited

Loading

KngZhi commented Apr 19, 2022

yangwao commented Apr 23, 2022

KngZhi commented Apr 25, 2022

vikiival left a comment

vikiival commented Apr 26, 2022

KngZhi commented Apr 26, 2022 •

edited by vikiival

Loading

KngZhi commented Apr 26, 2022 •

edited

Loading

yangwao commented May 5, 2022

yangwao commented May 5, 2022 •

edited

Loading

yangwao commented May 5, 2022

KngZhi commented May 5, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022 •

edited

Loading

vikiival commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

feat(2195): mini-pulse-history component #2884

feat(2195): mini-pulse-history component #2884

Conversation

KngZhi commented Apr 19, 2022 • edited Loading

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

kodabot commented Apr 19, 2022

netlify bot commented Apr 19, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

KngZhi commented Apr 19, 2022

yangwao commented Apr 23, 2022

KngZhi commented Apr 25, 2022

vikiival left a comment

Choose a reason for hiding this comment

vikiival commented Apr 26, 2022

KngZhi commented Apr 26, 2022 • edited by vikiival Loading

KngZhi commented Apr 26, 2022 • edited Loading

yangwao commented May 5, 2022

yangwao commented May 5, 2022 • edited Loading

yangwao commented May 5, 2022

KngZhi commented May 5, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

KngZhi commented May 6, 2022

yangwao commented May 6, 2022 • edited Loading

vikiival commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

yangwao commented May 6, 2022

KngZhi commented Apr 19, 2022 •

edited

Loading

netlify bot commented Apr 19, 2022 •

edited

Loading

KngZhi commented Apr 26, 2022 •

edited by vikiival

Loading

KngZhi commented Apr 26, 2022 •

edited

Loading

yangwao commented May 5, 2022 •

edited

Loading

yangwao commented May 6, 2022 •

edited

Loading