Colection required amount #6849

pbkompasz · 2023-08-21T10:14:42Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Display the deposit required to create a collection #6738
Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality

Optional

I've tested it at </ksm/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Did your issue had any of the "$" label on it?

Fill up your DOT address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

`🤖 Generated by Copilot at 5156e82`

This pull request adds a deposit feature for creating collections and enhances the user interface and feedback for this process. It introduces a variant prop for the SubmitButton component, uses the NeoField and NeoButtonVariant components from the @kodadot1/brick package, and updates the locales/en.json and utils/constants.ts files.

`🤖 Generated by Copilot at 5156e82`

SubmitButton shines
Creating collections with ease
Autumn of Neo

netlify · 2023-08-21T10:14:47Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`12f1a84`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64e4c8a7cde0af0008c07b3a
😎 Deploy Preview	https://deploy-preview-6849--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kodabot · 2023-08-21T10:14:47Z

SUCCESS @pbkompasz PR for issue #6738 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

reviewpad · 2023-08-21T10:15:09Z

AI-Generated Summary: This pull request includes five patches focused on several aspects of the code. Firstly, constants related to collection URLs and deposit amounts are added to a constants file. In the second patch, a variant attribute was added to the SubmitButton component, which allows this component to received a variant prop that modifies its appearance. Thirdly, strings relating to insufficient funds and deposit requirements have been added to the locale file to improve the application's internationalization. Fourthly, the message displayed when creating a collection was adjusted to provide more information about balance requirements and deposits. Finally, an unused import reference was removed from a collection creation component to improve the code's cleanliness and efficiency.

components/rmrk/Create/CreateCollection.vue

roiLeo

Why is this only available for rmrk Create collection? and it link towards AssetHub (Statemine) doc?

roiLeo · 2023-08-21T12:18:31Z

components/rmrk/Create/CreateCollection.vue

+            <a
+              v-safe-href="
+                'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint'
+              "
+              >Learn more</a
+            >


Suggested change

<a

v-safe-href="

'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint'

"

>Learn more</a

>

<a

v-safe-href="

https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint

"

>Learn more</a

>

missing translation helper.learnMore

Where should the 'Learn more' link to for /bsx?

Depends on the chain (urlPrefix) you're on

Each one has a different deposit value?

Yes, maybe bsx & snek has the same, I think it can be fetched through polkadot api package

The values should be fetched from the API or kept in the constants.js?

Should I use this?

nft-gallery/components/unique/apiConstants.ts

Line 15 in c4baf33

export function getclassDeposit(api: ApiPromise): bigint {

roiLeo · 2023-08-21T12:21:05Z

locales/en.json

@@ -35,6 +35,7 @@
  "facts": "Facts",
  "computed id": "Computed id",
  "create collection": "Create Collection",
+  "not enough funds": "Not Enough Funds",


duplicate of confirmPurchase.notEnoughFuns

components/rmrk/Create/CreateCollection.vue

locales/en.json

roiLeo · 2023-08-21T12:22:57Z

components/rmrk/Create/CreateCollection.vue

+a {
+  @include ktheme() {
+    color: theme('k-blue') !important;
+  }
+  text-decoration: underline;
+  white-space: nowrap;
+}


hmm... even on scoped component this can be smelly

The problem here is styling directly the a tag?

Yes there could be side effects If we'll use another a tag on this component

roiLeo · 2023-08-21T12:25:53Z

components/base/SubmitButton.vue


 export interface Props {
  disabled?: boolean
  expanded?: boolean
+  disabledIcon?: boolean


why don't you just check if there is icon prop behing passed?
something like:

const hasIcon = computed(() => +props.icon)

That wouldn't work because it has a default value (paper-plane). Should I remove the default value, but that might break functionality on other pages.

I don't think we'll keep this icon on all submit button in app, might be time to remove it.

components/base/SubmitButton.vue

components/bsx/Create/CreateCollection.vue

components/rmrk/Create/CreateCollection.vue

components/shared/CollectionDeposit.vue

roiLeo · 2023-08-22T07:53:17Z

components/shared/CollectionDeposit.vue

+    ? 'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint'
+    : 'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint?'


Based on previous comments I was under the impression that there should be a different link based on urlPrefix.
Is that correct? Can you also confirm what the links should be?

This link is for Ahk & Ahb prefix
for the other one it looks like the page havn't been written, maybe @yangwao can help?

roiLeo · 2023-08-22T07:54:00Z

components/shared/CollectionDeposit.vue

+const token = urlPrefix.value.toUpperCase()
+const requiredAmount =
+  token === 'KSM' ? COLLECTION_DEPOSIT_KSM : COLLECTION_DEPOSIT_BSX


check out assets page

/bsx 3 tokens and /snek shows 2. Which one is correct?

the one that you've set ie https://beta.kodadot.xyz/bsx/assets/

exezbcz · 2023-08-22T11:04:06Z

from the UI point of view, there should be an info icon, and the text inside button should be 16px

prury · 2023-08-22T13:11:56Z

RMRK1 showing that you need to have the RMRK token, but you need KSM.
The learn more button always redirect to the same Asset Hub Page on our docs, it should lead to the equivalent one in the chain you are:
@exezbcz maybe we should add a similar info when creating NFT aswell? lmk, i can open another issue for that

codeclimate · 2023-08-22T14:40:18Z

Code Climate has analyzed commit 12f1a84 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2023-08-22T14:40:20Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

exezbcz · 2023-08-22T18:15:15Z

@exezbcz maybe we should add a similar info when creating NFT aswell? lmk, i can open another issue for that

I think these things should be included in:

Simple Mint v2 #5939
you can create followup with this issue linked please

prury · 2023-08-24T16:25:04Z

how's this one? both assets hubs still missing the required amount message, right?

yangwao · 2023-08-29T09:26:50Z

Does this fix this one too?

In creating mint on we should calculate costs for existential deposit #7020

prury · 2023-08-30T23:43:34Z

Closing this one because no response and PR above prob solves it, can be reopened later if needed.

pbkompasz added 5 commits August 21, 2023 10:59

const: COLLECTION_DEPOSIT, learnMore

bc7e1ba

fix: Add variant

46d6519

locale

4d63931

feat: create collection submit message

d92c4ef

fix: unused imports

5156e82

pbkompasz requested a review from a team as a code owner August 21, 2023 10:14

pbkompasz requested review from roiLeo and Jarsen136 and removed request for a team August 21, 2023 10:14

reviewpad bot added small Pull request is small waiting-for-review labels Aug 21, 2023

pbkompasz added 2 commits August 21, 2023 13:19

fix: sonar-cloud xss warning

46bf2c6

fix: unused imports

21ef9eb

Jarsen136 reviewed Aug 21, 2023

View reviewed changes

components/rmrk/Create/CreateCollection.vue Outdated Show resolved Hide resolved

components/rmrk/Create/CreateCollection.vue Outdated Show resolved Hide resolved

components/rmrk/Create/CreateCollection.vue Outdated Show resolved Hide resolved

pbkompasz added 2 commits August 21, 2023 13:52

fix: add safe href

e7f0415

fix: disabled icon

46f4e37

roiLeo reviewed Aug 21, 2023

View reviewed changes

pbkompasz added 5 commits August 21, 2023 20:16

remove default icon

2032938

refactor: collection deposit message

62b18a1

locale

c75c659

refactor collection deposit values

7d33ec8

refactor: collection deposit component

d5ff609

reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 21, 2023

fix bug + warning

b713ced

roiLeo suggested changes Aug 22, 2023

View reviewed changes

fix

ac607af

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 22, 2023

pbkompasz added 2 commits August 22, 2023 17:26

SubmitButton font size

a29c5a4

add icon; fix token

12f1a84

prury mentioned this pull request Aug 22, 2023

Add NFT creation cost on the NFT creation UI #6892

Closed

prury closed this Aug 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Colection required amount #6849

Colection required amount #6849

pbkompasz commented Aug 21, 2023 •

edited by ghost

Loading

netlify bot commented Aug 21, 2023 •

edited

Loading

kodabot commented Aug 21, 2023

reviewpad bot commented Aug 21, 2023

roiLeo left a comment

roiLeo Aug 21, 2023

pbkompasz Aug 21, 2023 •

edited

Loading

roiLeo Aug 21, 2023

pbkompasz Aug 21, 2023

roiLeo Aug 22, 2023

pbkompasz Aug 22, 2023

pbkompasz Aug 22, 2023

roiLeo Aug 21, 2023

roiLeo Aug 21, 2023

pbkompasz Aug 21, 2023

roiLeo Aug 22, 2023

roiLeo Aug 21, 2023

pbkompasz Aug 21, 2023

roiLeo Aug 21, 2023

roiLeo Aug 22, 2023

pbkompasz Aug 22, 2023

roiLeo Aug 22, 2023

roiLeo Aug 22, 2023

pbkompasz Aug 22, 2023

roiLeo Aug 22, 2023

exezbcz commented Aug 22, 2023

prury commented Aug 22, 2023

codeclimate bot commented Aug 22, 2023

sonarcloud bot commented Aug 22, 2023

exezbcz commented Aug 22, 2023

prury commented Aug 24, 2023

yangwao commented Aug 29, 2023

prury commented Aug 30, 2023

		? 'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint'
		: 'https://hello.kodadot.xyz/multi-chain/fees/assethub-fees#polkadot-asset-hub-fees-prev.-statemint?'

Colection required amount #6849

Colection required amount #6849

Conversation

pbkompasz commented Aug 21, 2023 • edited by ghost Loading

PR Type

Context

Before submitting pull request, please make sure:

Optional

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at 5156e82

🤖 Generated by Copilot at 5156e82

netlify bot commented Aug 21, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

kodabot commented Aug 21, 2023

reviewpad bot commented Aug 21, 2023

roiLeo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pbkompasz Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

exezbcz commented Aug 22, 2023

prury commented Aug 22, 2023

codeclimate bot commented Aug 22, 2023

sonarcloud bot commented Aug 22, 2023

exezbcz commented Aug 22, 2023

prury commented Aug 24, 2023

yangwao commented Aug 29, 2023

prury commented Aug 30, 2023

pbkompasz commented Aug 21, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 5156e82`

`🤖 Generated by Copilot at 5156e82`

netlify bot commented Aug 21, 2023 •

edited

Loading

pbkompasz Aug 21, 2023 •

edited

Loading