#3278 Limit input for user could not submit lower than minimum offer …

[prachi00]

…size

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• PR closes Limit input for user could not submit lower than minimum offer size #3278

• PR closes Invalid prop: tooltipOfferLabel #3361

• Requires deployment <rubick/magick_issue>

• <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
• I've tested PR on mobile and everything seems works
• I found edge cases
• I've written some unit tests 🧪

Had issue bounty label?

• Fill up your KSM address:
  Payout

Community participation

• Are you at KodaDot Discord?

Screenshot

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

WARNING @prachi00 PR for issue #3278 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3278

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	53ccabf
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62c8599ad619a60008f8a786
😎 Deploy Preview	https://deploy-preview-3324--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

This could work out but I think a better solution would be to update min attribute from BalanceInput component

[prachi00]

BalanceInput

yeah it wont work tho because even if the input will throw error, button will not be disabled and user can still click on it, so we kinda do need he disabled attribute on the button

[roiLeo]

This could work out but I think a better solution would be to update min attribute from BalanceInput component

max attribute could be user balance ref #3346

[roiLeo]

yeah it wont work tho because even if the input will throw error, button will not be disabled and user can still click on it, so we kinda do need he disabled attribute on the button

Things is I find disabled "buttons/switch/inputs" a bad design pratice, this issue can be solved using simple html form validation.

You solution is working but mobile experience will be bad since user won't be able to know why the button is disabled.

[yangwao]

You solution is working but mobile experience will be bad since user won't be able to know why the button is disabled.

(In safari,) Do you need to connect your wallet first? 👀 Or do you mean like for Nova wallet?

You solution is working but mobile experience will be bad since user won't be able to know why the button is disabled.

Let's create a separate issue for a mobile experience @roiLeo ?

[roiLeo]

I just feel like we're making it harder for ourselves, instead I would like to see a simple form

[prachi00]

@roiLeo used min max and buefy input validation method to check it now

[roiLeo]

min is always same value for me (10 000), could you check why?

Form validation looks way better now! didn't knew about buefy checkHtml5Validity method

[prachi00]

not sure about min (calculating through api.consts.marketplace.minimumOfferAmount), its 10k for me too, its probably fixed?

[roiLeo]

not sure about min (calculating through api.consts.marketplace.minimumOfferAmount), its 10k for me too, its probably fixed?

this looks like it will always be at 10k since it's not related to current item

@vikiival any idea where we can find documentation of this feature?

[vikiival]

@vikiival any idea where we can find documentation of this feature?

Unfortunately no.

The code is currently set to 10k
https://github.com/galacticcouncil/Basilisk-node/blob/b3b0b63c0b4098b0f0ca18ac43e748da85540f7c/runtime/basilisk/src/lib.rs#L803
But it can change so I would use api.consts.marketplace.minimumOfferAmount instead of setting 10k there

Also be aware that the api call can return you a special type (like u128) so you need to apply proper formatting

[prachi00]

@roiLeo can we merge this now?

[yangwao]

Seems on account with 19000 bsx

is ok

when I submit offer for 21000 BSX where account balance is 19000 bsx got error, could be fixed in #3346

#3361 seems doesn't happen to me

[yangwao]

pay 50 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $50 @ 52.86 USD/KSM ~ 0.946 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xd37fd1edfc3485cf72d95659aa44d8a4322605ae3d5490e6046c3f652f8329f9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues