Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure if user has enough funds to make offer (decimal points) #3346

Closed
Tracked by #660 ...
yangwao opened this issue Jul 6, 2022 · 11 comments · Fixed by #3391
Closed
Tracked by #660 ...

Make sure if user has enough funds to make offer (decimal points) #3346

yangwao opened this issue Jul 6, 2022 · 11 comments · Fixed by #3391
Labels
$ ~<50usd A-basilisk issues related to basilisk parachain bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Jul 6, 2022

Seems we don't check whether users can submit a higher offer than has the amount of balance on own account?
EDIT seems different kind of issue plus it's related to LIST, check screenshot below

Screen.Recording.2022-07-06.at.15.12.30.mov

image

Seems related when you doing LIST as well

image

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-basilisk issues related to basilisk parachain labels Jul 6, 2022
@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Jul 6, 2022

ASSIGNED - @Jarsen136 🔒 LOCKED -> Friday, July 8th 2022, 01:16:57 UTC -> 36 hours

@yangwao
Copy link
Member Author

yangwao commented Jul 7, 2022

@Jarsen136 found it happens for LIST as well

@Jarsen136
Copy link
Contributor

@Jarsen136 found it happens for LIST as well

ok, I will check them

@yangwao yangwao changed the title Check if user can make offer higher than balance Check if user can make offer higher than balance (decimal points) Jul 7, 2022
@yangwao yangwao changed the title Check if user can make offer higher than balance (decimal points) Make sure if user has enough funds to make offer (decimal points) Jul 7, 2022
@Jarsen136
Copy link
Contributor

As @roiLeo mentioned here #3324 (comment), this issue is quite related to it. So, let's wait till the PR merged.

@kodabot
Copy link
Collaborator

kodabot commented Jul 8, 2022

ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned.

@petersopko petersopko mentioned this issue Jul 8, 2022
89 tasks
@yangwao
Copy link
Member Author

yangwao commented Jul 9, 2022

As @roiLeo mentioned here #3324 (comment), this issue is quite related to it. So, let's wait till the PR merged.

you can check this one if you want so :)

@yangwao
Copy link
Member Author

yangwao commented Jul 9, 2022

Seems we already handle some sort of "max", but not available amount of user balance

image

@Jarsen136 Jarsen136 self-assigned this Jul 9, 2022
@kodabot
Copy link
Collaborator

kodabot commented Jul 9, 2022

ASSIGNED ISSUES LIMIT REACHED - @Jarsen136, you have been already assigned with 5 issues: 3142,3321,3378,3385,3387. Finish one of them in order to get more issues assigned!

@Jarsen136
Copy link
Contributor

As @roiLeo mentioned here #3324 (comment), this issue is quite related to it. So, let's wait till the PR merged.

you can check this one if you want so :)

Oki, I will check it.

@prachi00
Copy link
Member

prachi00 commented Jul 9, 2022

Seems we already handle some sort of "max", but not available amount of user balance

image

max is set as user balance, probably some formatting issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-basilisk issues related to basilisk parachain bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants