-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add max buy and reorder collection #2556
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Like the code is legit, but it's like using duct tape to glue two pieces of paper together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query totalCollectionEvents($id: ID!, $and: [EventWhereInput!]) {
list: eventsConnection(where: {nft: {collection: {id_eq: $id}}, AND: $and }, orderBy: meta_DESC) {
count: totalCount
}
max: events(where: {nft: {collection: {id_eq: $id}}, AND: $and }, orderBy: meta_DESC, limit: 1) {
id
meta
}
}
Thanks for your idea! This solution can get the 'totalCount' correctly, but don't work well on 'max' because of the sorting method. Meta is a string type so that the sorting result is not correct. I think we need a custom sorting method in graphql. graphql/graphql-spec#8 Any ideas? @vikiival |
Yup, we need to write the resolver to the kodadot/rubick which will return the correct max and count |
Thanks, I will have a try! |
Now it needs to redeploy 👀 |
Waiting to resolve kodadot/rubick#37 |
Hi, it seems that the new resolver has been merged into main branch. I wonder when it will be deployed well so that I could change the frontend code. @vikiival |
@Jarsen136 🦑 should be up in a couple of minutes |
Can we test this so we can launch it with the upcoming push to production? cc @vikiival |
yup |
@Jarsen136 please add translations and we are good to go 🫣 |
pay 300 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot