Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on collection stats with max buy #2745

Closed
yangwao opened this issue Apr 2, 2022 · 4 comments · Fixed by #2750
Closed

Follow up on collection stats with max buy #2745

yangwao opened this issue Apr 2, 2022 · 4 comments · Fixed by #2750
Labels
$ ~<50usd A-collection work being done collection view p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Apr 2, 2022

Follow up issue

  • change "purchases" -> "buys", it's shorter
  • add translations
  • plus fix horizontal alignment
    image

Originally posted by @yangwao in #2556 (comment)
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-collection work being done collection view labels Apr 2, 2022
@Jarsen136
Copy link
Contributor

I will do this.

@Jarsen136
Copy link
Contributor

I'm not sure what 'add translations' means. Does It mean that I need to add the English translation key in en.json . Other languages ​​don't need it, right?

@prachi00
Copy link
Member

prachi00 commented Apr 2, 2022

Yes @Jarsen136 add in en.json thats it

@Jarsen136
Copy link
Contributor

Yes @Jarsen136 add in en.json thats it

Thanks. I Got it!

@Jarsen136 Jarsen136 mentioned this issue Apr 2, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd A-collection work being done collection view p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

justify collection stats with max buy Jarsen136/nft-gallery
3 participants
@yangwao @Jarsen136 @prachi00