Fix http server not binding to '::' by default (regression)
#8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca40242:
|
|
|
dcousens
force-pushed
the
fix-binding
branch
from
e1ccf1b
to
a7a9665
Compare
borisno2
approved these changes
Nov 21, 2022
dcousens
force-pushed
the
fix-binding
branch
from
ef54d38
to
ca40242
Compare
Merged
dcousens
added a commit
that referenced
this pull request
Nov 21, 2022
dcousens
added a commit
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #8103, which outlined that
"@keystone-6/core": "3.1.1"introduced a regression that accidentally changed that behaviour.This pull request does not revert #8078, but instead fixes the regression by explicitly defaulting to
::.