Fix the startup message to use the configured http.options host, don't assume localhost
#8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0934e05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0934e05:
|
|
I noticed that the behavior is incorrect when not configured. I mark this PR as a draft until I finish fixing it. |
|
Made it work correctly even if host is not configured. |
dcousens
changed the title
http.options host, don't instead of assuming localhost
dcousens
changed the title
http.options host, don't instead of assuming localhosthttp.options host, don't assume localhost
Merged
This was referenced Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the configured host instead of localhost when starting Keystone.
I checked that the log has changed by sandbox.
This PR is related to #7852.
I searched all codes that uses
localhost, and it looks like there is no other code that needs fixing.They were mostly example READMEs and test codes.
Also, #7852 reported that the Admin UI was broken, but now it seems to work.
Please let me know if I have overlooked anything.