Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc bugfixes #620

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Misc bugfixes #620

merged 10 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. statd: add missing default {} when snooping is disabled 

    When multicast snooping is disabled on a bridge, mctl will exit with a
non-zero return code.  Default to {} for these cases so that the bridge
and its ports are properly returned by yanger.

Fixes #618

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6b6dd7d View commit details
    Browse the repository at this point in the history

  2. cli: fix regression in tab completion of 'container shell ...' 

    Only administrators are allowed to work with containers, allow them to
perform tab completion of all admin-exec commands as well.

Fixes #613

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f4442b4 View commit details
    Browse the repository at this point in the history

  3. cli: show configured name servers in 'show dns' command 

    Before we add proper operational support for DNS and NTP, we can at
least improve on the built-in CLI commands.

Issue #510

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6cd851e View commit details
    Browse the repository at this point in the history

  4. statd: silence bogus log warnings 

    With a basic bridge setup, which has multicast snooping disabled by
default, `show interfaces` cause the following bogus log messages:

Sep 13 07:08:35 yanger: Command '['mctl', 'show', 'igmp', 'json']' returned non-zero exit status 1
Sep 13 07:08:35 yanger: Command '['mctl', 'show', 'igmp', 'json']' returned non-zero exit status 1
Sep 13 07:08:35 yanger: Command '['mctl', '-p', 'show', 'igmp', 'json']' returned non-zero exit status 1

Add a quiet flag to the run methods and set quiet=True for all mctl
commands to silence these log messages.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3699b53 View commit details
    Browse the repository at this point in the history

  5. board/common: spellcheck path to downloaded OCI files 

    Check correct path for downloaded container images.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e031119 View commit details
    Browse the repository at this point in the history

  6. board/common: add container --net IFNAME locate 

    Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5747042 View commit details
    Browse the repository at this point in the history

  7. Fix container upgrade regression 

    In 0edc2d5 and afbe5ca, just prior to v24.06.0-rc1, support for deleting
containers in the background was added.  However, this also broke support
for upgrading containers.

In afbe5ca the start script for containers was renamed from NAME.sh to
S01-NAME.sh, but the container wrapper script's upgrade command was not
updated.  Neither was the cleanup and post-hook callbacks in confd!  So
when a container had been added to the system, the cleanup callback just
simply deleted the script, preventing it from being recreated at ugprade

This patch fixes the container identification code and also refactors
the execd code to ensure that kill scripts (for deleting in background)
and start scripts are run in the proper order *and* ensuring that execd
also does not accidentally remove the container start script.

Some cosmetic changes to the output at upgrade have also been added.

Fixes #623

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    df2d148 View commit details
    Browse the repository at this point in the history

  8. doc: minor update, missing period + grammar 

    Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    06379c0 View commit details
    Browse the repository at this point in the history

  9. doc: adjust ChangeLog entry, issue fixed in v24.09, not v24.04 

    Follow-up to cfd95dc

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    09c4449 View commit details
    Browse the repository at this point in the history

  10. doc: update ChangeLog with fixes 

    Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
    @troglobit
    troglobit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    56a371b View commit details
    Browse the repository at this point in the history