Misc bugfixes #620
Merged
Misc bugfixes #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 12, 2024
troglobit
force-pushed
the
misc-bugfixes
branch
2 times, most recently
from
36fa231
to
1cc1655
Compare
troglobit
force-pushed
the
misc-bugfixes
branch
from
1cc1655
to
54df3f3
Compare
wkz
approved these changes
Sep 13, 2024
troglobit
force-pushed
the
misc-bugfixes
branch
3 times, most recently
from
e0a7020
to
2d89722
Compare
When multicast snooping is disabled on a bridge, mctl will exit with a
non-zero return code. Default to {} for these cases so that the bridge
and its ports are properly returned by yanger.
Fixes #618
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Only administrators are allowed to work with containers, allow them to perform tab completion of all admin-exec commands as well. Fixes #613 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Before we add proper operational support for DNS and NTP, we can at least improve on the built-in CLI commands. Issue #510 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
With a basic bridge setup, which has multicast snooping disabled by default, `show interfaces` cause the following bogus log messages: Sep 13 07:08:35 yanger: Command '['mctl', 'show', 'igmp', 'json']' returned non-zero exit status 1 Sep 13 07:08:35 yanger: Command '['mctl', 'show', 'igmp', 'json']' returned non-zero exit status 1 Sep 13 07:08:35 yanger: Command '['mctl', '-p', 'show', 'igmp', 'json']' returned non-zero exit status 1 Add a quiet flag to the run methods and set quiet=True for all mctl commands to silence these log messages. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Check correct path for downloaded container images. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
In 0edc2d5 and afbe5ca, just prior to v24.06.0-rc1, support for deleting containers in the background was added. However, this also broke support for upgrading containers. In afbe5ca the start script for containers was renamed from NAME.sh to S01-NAME.sh, but the container wrapper script's upgrade command was not updated. Neither was the cleanup and post-hook callbacks in confd! So when a container had been added to the system, the cleanup callback just simply deleted the script, preventing it from being recreated at ugprade This patch fixes the container identification code and also refactors the execd code to ensure that kill scripts (for deleting in background) and start scripts are run in the proper order *and* ensuring that execd also does not accidentally remove the container start script. Some cosmetic changes to the output at upgrade have also been added. Fixes #623 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Follow-up to cfd95dc Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
misc-bugfixes
branch
from
2d89722
to
56a371b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc. fixes to annoying regressions and missing functionality.
Checklist
Tick relevant boxes, this PR is-a or has-a: