Minor Coverity Scan fixes #594
Merged
Commits on Sep 2, 2024
-
confd: constify, found by clang-tidy
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
-
confd: fix variable overloading, global xpath unused
Found by clang-tidy Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
-
confd: reduce scope of local variables
Found by clang-tidy Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
-
confd: minor, reduce complexity
- Silence linter, add braces - Unindent code block to reduce complexity Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
-
confd: fix possible NULL pointer dereference
The srx_get_str() function may return NULL, which goes unchecked in both fxlate() and sxlate(), as well as the calls to free(). Found by Coverity Scan Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
-
confd: unchecked return value from remove()
Not much we can do, other than log and report. Found by Coverity Scan Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.