Minor Coverity Scan fixes #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Found by clang-tidy Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Found by clang-tidy Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
- Silence linter, add braces - Unindent code block to reduce complexity Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
mattiaswal
reviewed
Sep 2, 2024
The srx_get_str() function may return NULL, which goes unchecked in both fxlate() and sxlate(), as well as the calls to free(). Found by Coverity Scan Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Not much we can do, other than log and report. Found by Coverity Scan Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
coverity-fixes
branch
from
5d7d8aa
to
3b1415d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor Coverity weekly scan issues as well as some linter warnings from clang-tidy.
Checklist
Tick relevant boxes, this PR is-a or has-a: