Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgetting pvid, fixing only that in configuration, only takes after reboot #349

Closed
troglobit opened this issue Mar 20, 2024 · 0 comments · Fixed by #352
Closed

Forgetting pvid, fixing only that in configuration, only takes after reboot #349

troglobit opened this issue Mar 20, 2024 · 0 comments · Fixed by #352
Labels
bug Something isn't working
Milestone
Infix v24.04

Comments

@troglobit
Copy link
Contributor

When setting up VLANs I of course forgot about how important the bridge-port pvid setting is. So I tried to correct my mistake at runtime by entering the CLI and adding pvid to all bridge ports.

No success 😢

Saving running-config and rebooting, however, worked.

In addition to fixing the issue (not taking until after reboot), we should either derive/infer (post leave) PVID for untagged ports, or warn users with a YANG must expression.

Any comments, ideas, suggestions @wkz and @mattiaswal?
@troglobit troglobit added the bug Something isn't working label Mar 20, 2024
troglobit added a commit that referenced this issue Mar 21, 2024
@troglobit
confd: handle small changes to bridge port properties
413db52 
This patch adds support for small incremental changes to bridge ports.
Changes where the libyang diff does not include a bridge reference so
that it will have to be synthesized from the current configuration.

For example, forgetting to set a port's PVID in a VLAN filtering bridge
setup, changing a bridge port's multicast flooding properties, or any
other per-bridge-port setting after the fact.

Fixes #349.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit mentioned this issue Mar 21, 2024
Merged
13 tasks
@troglobit troglobit linked a pull request Mar 21, 2024 that will close this issue
Bump mcd and adapt confd, also bridge-port bug fix #352
Merged
13 tasks
troglobit added a commit that referenced this issue Mar 21, 2024
@troglobit
confd: handle small changes to bridge port properties
82a6247 
This patch adds support for small incremental changes to bridge ports.
Changes where the libyang diff does not include a bridge reference so
that it will have to be synthesized from the current configuration.

For example, forgetting to set a port's PVID in a VLAN filtering bridge
setup, changing a bridge port's multicast flooding properties, or any
other per-bridge-port setting after the fact.

Fixes #349.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@mattiaswal mattiaswal mentioned this issue Mar 21, 2024
Closed
@troglobit troglobit mentioned this issue Mar 21, 2024
Open
@wkz wkz closed this as completed in #352 Mar 22, 2024
wkz pushed a commit that referenced this issue Mar 22, 2024
@troglobit @wkz
confd: handle small changes to bridge port properties
3ebbd0b 
This patch adds support for small incremental changes to bridge ports.
Changes where the libyang diff does not include a bridge reference so
that it will have to be synthesized from the current configuration.

For example, forgetting to set a port's PVID in a VLAN filtering bridge
setup, changing a bridge port's multicast flooding properties, or any
other per-bridge-port setting after the fact.

Fixes #349.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added this to the Infix v24.04 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Infix v24.04
Development

Successfully merging a pull request may close this issue.

Bump mcd and adapt confd, also bridge-port bug fix kernelkit/infix
1 participant
@troglobit