Clear scalers cache correctly both in Operator and Metrics Server #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
|
/run-e2e |
|
@zroubalik I've just tested the change I am working on (#2495) against this PR. This PR resolves the issue I described in Slack (the metrics server -- but not the operator -- failing to reload secrets in response to auth failures). I now see one auth failure in the logs at credential expiration time, followed by success once the creds have been reloaded. |
JorTurFer
approved these changes
Jan 27, 2022
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
…dacore#2564) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
…dacore#2564) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa
added a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
author Mark Rzasa <mark.rzasa@gmail.com> 1642970493 -0500 committer Mark Rzasa <mark.rzasa@nuance.com> 1643317483 -0500 app insights scaler Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com> Add PredictKube scaler (kedacore#2418) Signed-off-by: Daniel Yavorovych <daniel@dysnix.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com> bump deps (kedacore#2563) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Clear scalers cache correctly both in Operator and Metrics Server (kedacore#2564) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> test: Provide e2e secrets for Azure Application Insights scaler (kedacore#2568) Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
markrzasa
added a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
author Mark Rzasa <mark.rzasa@gmail.com> 1642970493 -0500 committer Mark Rzasa <mark.rzasa@nuance.com> 1643317483 -0500 app insights scaler Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com> Add PredictKube scaler (kedacore#2418) Signed-off-by: Daniel Yavorovych <daniel@dysnix.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com> bump deps (kedacore#2563) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Clear scalers cache correctly both in Operator and Metrics Server (kedacore#2564) Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> test: Provide e2e secrets for Azure Application Insights scaler (kedacore#2568) Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Mark Rzasa <mark.rzasa@nuance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
This fix should correctly clear/invalidate cache in both KEDA Operator and Metrics Server, when ScaledObject is deleted from cluster, when there is a problem in resolving secrets/credentials or when there is a general problem in scraping metrics from a scaler.
The previous fix #2408 worked only partially - in KEDA Operator, because it didn't use
ClearScalersCache()function, but tried to delete the map entry directly. But the main problem was, that theClearScalersCache()which is being used in Metrics Server, operated on a wrong key, ie.name.namespaceinstead ofkind.namespace.namegenerated bywithTriggers.GenerateIdenitifier(). That resulted in cache not being invalidated in Metrics Server.Checklist
Fixes #2407