Delete the cache entry when a ScaledObject is deleted #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
|
I'm not sure about the best way to test this change. Maybe as a test inside |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
|
I'm not sure if waiting with sleep is worth (I guess that it isn't... Is there a better way to do that test? |
I'm guessing you want to wait until the SO is deleted right? You could use the foreground deletion policy as noted in a comment on this post. |
zroubalik
approved these changes
Jan 3, 2022
zroubalik
changed the title
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jan 4, 2022
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
zroubalik
added a commit
that referenced
this pull request
Jan 4, 2022
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
alex60217101990
pushed a commit
to dysnix/keda
that referenced
this pull request
Jan 10, 2022
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com>
alex60217101990
pushed a commit
to dysnix/keda
that referenced
this pull request
Jan 10, 2022
Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com>
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
Provide a description of what has been changed
Checklist
Fixes #2407