Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pageSize (using regex) in RabbitMQ Scaler #2162

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 6, 2021

Signed-off-by: jorturfer jorge_turrado@hotmail.es

After discussed it in this PR about if RabbitMQ should support pagination browsing (using regex), we decided to don't support it but add an extra parameter to support setting the page size.
This PR adds support to the pageSize value in order to bring the option to increase from 100 (default value in RabbitMQ).

Checklist

Fixes #2068

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

Could you trigger again the CI?
In my local it doesn't fail, and I didn't change anything related with that test :/
image

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 459203a into kedacore:main Oct 7, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@JorTurFer JorTurFer deleted the rabbitmq_page_size branch November 5, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to browse over the pages using regex in RabbitMQ Scaler
2 participants