Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pageSize parameter in RabbitMQ Scaler #546

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Document pageSize parameter in RabbitMQ Scaler #546

merged 2 commits into from
Oct 7, 2021

Conversation

JorTurFer
Copy link
Member

This PR documents pageSize parameter and fixes some errors in RabbitMQ docs styles (I can split these last changes into another PR if you want)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related kedacore/keda#2162

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@tomkerkhove
Copy link
Member

Can you merge master please?

@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 7, 2021

Sure, I will do it during the day :) (I'm AFK)
The PR is up to date with Master. Why did you think the oposite?
Maybe because I added some style fixes? If it's because that, we missed them in the other PR IDK how :(

@tomkerkhove tomkerkhove merged commit 95463d3 into kedacore:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants