Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation logic for hub.extraConfig as a string #2307

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Remove deprecation logic for hub.extraConfig as a string #2307

merged 3 commits into from
Jul 9, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jul 8, 2021 •
edited
Loading

Closes #2063 by:

  • updating the documentation to reflect it must be a dictionary as have been enforced by schema in JupyterHub 1.0.0 and was deprecated in 0.8.0.
  • removing logic to handle hub.extraConfig being a string in our jupyterhub_config.py file that now assumes its a dictionary instead

@consideRatio consideRatio changed the title pr/remove deprecation logic for hub.extraConfig Remove deprecation logic for hub.extraConfig as a string Jul 8, 2021
manics
manics reviewed Jul 9, 2021
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/source/administrator/advanced.md Outdated Show resolved Hide resolved
doc/source/administrator/advanced.md Outdated Show resolved Hide resolved
@consideRatio @manics
Apply suggestions from code review
05f6db4 
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
@consideRatio
Copy link
Member Author

Thanks for the review work @manics! ❤️

@consideRatio consideRatio merged commit e9db5aa into jupyterhub:main Jul 9, 2021
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jul 9, 2021
[jupyterhub] Automatic update for commit 1.0.1-n026.ha16f40bf
67ae622 
jupyterhub/zero-to-jupyterhub-k8s#2307 Merge pull request #2307 from consideRatio/pr/remove-deprecation-logic-for-hub.extraConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics left review comments

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hub.extraConfig as a string is not supported - update docs and remove potential related logic
2 participants
@consideRatio @manics