You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation claims that extraConfig accepts either a dict of strings or a single string (of Python code), but it actually only accepts the first one. If you give it a single string, following the documented example, it warns
coalesce.go:196: warning: cannot overwrite table with non table for extraConfig (map[])
and it does not take effect. See #653 which seems to observe the same issue.
Action point
Reproduce and conclude that helm 3 and 0.11.1 that this doesn't work.
hub:
extraConfig: | print("THIS SHOULD BE SEEN IN LOGS ON STARTUP, IS IT?")
The text was updated successfully, but these errors were encountered:
We have apparently made it stop working entirely no matter what in 1.0.0 where we introduced schema validation.
helm template --repo https://jupyterhub.github.io/helm-chart/ jupyterhub --set hub.extraConfig="print('test')"
coalesce.go:200: warning: cannot overwrite table with non table for extraConfig (map[])
Error: values don't meet the specifications of the schema(s) in the following chart(s):
jupyterhub:
- hub.extraConfig: Invalid type. Expected: object, given: string
I suggest we drop this as: a) it is already dropped unintentionally, b) it is a bad practice as one can only have one extraConfig entry, and c) it increase the complexity of the helm chart, d) it was deprecated as of z2jh 0.8.0
As an action point, we should make sure we drop the complexity related to allowing this config to be a string.
Remove documentation about hub.extraConfig as a string (advanced.md includes this!)
Remove logic if there is such to support hub.extraConfig being a string rather than a dict.
consideRatio
changed the title
Is passing a string still really supported for hub.extraConfig?
hub.extraConfig as a string is not supported - update docs and remove potential related logic
Jul 6, 2021
As reported by @danielballan in #2062 (comment) (point 1), it may not be supported for us to set hub.extraConfig to a string.
Action point
Reproduce and conclude that helm 3 and 0.11.1 that this doesn't work.
The text was updated successfully, but these errors were encountered: