Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ag grid theme header text color should be secondary color #3065

Closed
3 of 10 tasks
origami-z opened this issue Feb 28, 2024 · 0 comments · Fixed by #3068
Closed
3 of 10 tasks

Ag grid theme header text color should be secondary color #3065

origami-z opened this issue Feb 28, 2024 · 0 comments · Fixed by #3068
Labels
community For issues that have been raised by folks outside the core Salt team package: ag-grid-theme status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working

Comments

@origami-z
Copy link
Contributor

Package name(s)

AG Grid Theme (@salt-ds/ag-grid-theme)

Package version(s)

1.3.8

Description

It's primary color in storybook but secondary in Figma.

Steps to reproduce

https://storybook.saltdesignsystem.com/?path=/story/data-grid-ag-grid-theme--basic-grid

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. package: ag-grid-theme community For issues that have been raised by folks outside the core Salt team labels Feb 28, 2024
@origami-z origami-z mentioned this issue Feb 29, 2024
Merged
origami-z added a commit that referenced this issue Feb 29, 2024
@origami-z
Grid header text use secondary color #3065
e181d63
origami-z added a commit that referenced this issue Feb 29, 2024
@origami-z
Grid header text use secondary color #3065
b242330
origami-z added a commit that referenced this issue Feb 29, 2024
@origami-z
Grid header text use secondary color #3065
1c3b028
joshwooding pushed a commit that referenced this issue Mar 1, 2024
@origami-z
Grid header text use secondary color #3065 (#3068)
7bbbab9
lukeac123 pushed a commit that referenced this issue Mar 1, 2024
@origami-z @lukeac123
Grid header text use secondary color #3065 (#3068)
3f58196
@origami-z origami-z mentioned this issue Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team package: ag-grid-theme status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grid header text use secondary color #3065 jpmorganchase/salt-ds
1 participant
@origami-z