Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt AG-Grid theme supports v29+ ag grid #2103

Closed
18 of 19 tasks
Tracked by #2104
origami-z opened this issue Jul 31, 2023 · 22 comments
Closed
18 of 19 tasks
Tracked by #2104

Salt AG-Grid theme supports v29+ ag grid #2103

origami-z opened this issue Jul 31, 2023 · 22 comments
Assignees
Milestone

Comments

@origami-z
Copy link
Contributor

origami-z commented Jul 31, 2023

Currently ag grid is using Legacy SASS method to generate CSS, and need to move to new way.

Also new versions of ag grid introduced proper CSS like below

[class*=ag-theme-] {
   ...
    --ag-background-color: #fff;
   ...
}

These will override Salt colors applied, so will need to follow new way of overriding colors.

StackBlitz Demo of ag grid v30 CSS variable breaking styling.

Tasks

  1. package: ag-grid-theme
  2. alycrys
  3. package: ag-grid-theme
    alycrys
  4. package: ag-grid-theme role: content 📝 role: dev 💻
    alycrys
  5. role: design 🎨 role: dev 💻
    pseys shey-v
@joshwooding
Copy link
Contributor

You beat me to creating this, we've already discussed the next set of actions, and moving to the new CSS approach is part of it

@origami-z
Copy link
Contributor Author

Updated release date, as work has not started.

@origami-z
Copy link
Contributor Author

update target date to match subtask

@origami-z
Copy link
Contributor Author

origami-z commented Oct 23, 2023

25 Oct - Chromatic snapshot to be design reviewed with @bhoppers2008
23 Oct - cypress snapshot test merged to next branch. Fixing conflict from main, will continue feedback afterwards.

@joshwooding
Copy link
Contributor

Moved the target date to 31st Oct to accommodate feedback from consumers

@joshwooding
Copy link
Contributor

Hard-coded colours need to be removed and mapped to Salt colours.

@origami-z
Copy link
Contributor Author

3 Nov - PR ready for review, moving to feedback stage

@shey-v
Copy link
Contributor

shey-v commented Nov 6, 2023

6 Nov - PR reviews and waiting for more to be able to merge. @joshwooding

@joshwooding
Copy link
Contributor

joshwooding commented Nov 8, 2023

Almost ready, creating tests for UITK theme. Consumers not able to test the theme yet as they haven't begun their upgrade. PR still needs a review

@origami-z
Copy link
Contributor Author

13 Nov - PR review requested this morning, Chromaticc tests added for uItk theme

@origami-z
Copy link
Contributor Author

origami-z commented Nov 17, 2023

17 Nov - Fixing UITK theme to match on Chromatic / Cypress.

@origami-z
Copy link
Contributor Author

20 Nov - wip, more test to be fixed. ETA tmr

@origami-z
Copy link
Contributor Author

22 Nov - dev done. verifying test passing, review for dev & design review (both Salt and UITK theme).

@origami-z
Copy link
Contributor Author

24 Nov - snapshot tests pass. Range selection bug raised. Can't merge to main, bug fixes needed for v1.

@origami-z
Copy link
Contributor Author

27 Nov - doc changes on ag grid next branch.

@origami-z
Copy link
Contributor Author

origami-z commented Dec 1, 2023

1 Dec - trying at snapshot (help from @lukeac123), at feedback stage. Keep in next branch.

@origami-z
Copy link
Contributor Author

4 Dec - trying snapshot by @lukeac123. More thorough test needed.

@origami-z
Copy link
Contributor Author

6 Dec - more tests to be added for range selection. discuss how to manage 2 ag grid theme version.

@origami-z
Copy link
Contributor Author

8 Dec - Need additional icon (drag and drop row, GH issue? @pseys did it). Version management to be discussed.

@origami-z
Copy link
Contributor Author

11 Dec - icons created, needs to be added to the icon font (how? to be confirmed). Version management to be discussed.

@joshwooding
Copy link
Contributor

18 Dec - Icons have been merged, and the data grid theme has been updated with the new icons.

@origami-z origami-z self-assigned this May 30, 2024
@origami-z
Copy link
Contributor Author

Closed by #3195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment