Fix #33 ? #34
Merged
Fix #33 ? #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could still be much better.
|
This is untested. |
|
Ah you have a PR - thank you :) will check it out soon |
jpillora
reviewed
Feb 3, 2023
handler/strings.go
Outdated
| @@ -6,7 +6,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| archRe = regexp.MustCompile(`(arm64|arm|386|amd64|32|64)`) | |||
| archRe = regexp.MustCompile(`(arm64|arm|386|amd64|32|64|x86_64|aarch64)`) | |||
There was a problem hiding this comment.
can you plz move these to the front? otherwise it'll return "64"
There was a problem hiding this comment.
I did try it here[1] beforehand it seemed to macht the longest, but I can change regardless.
There was a problem hiding this comment.
Oh interesting, TIL
will test in Go soon and confirm
|
Just one minor change, otherwise LGTM |
|
Merged, should go live soon via CI thanks! (heading off to sleep 🤞) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could still be much better.