Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong parsed arch on casey/just #33

Closed
jpambrun opened this issue Feb 3, 2023 · 2 comments
Closed

wrong parsed arch on casey/just #33

jpambrun opened this issue Feb 3, 2023 · 2 comments
Labels

Comments

@jpambrun
Copy link
Contributor

jpambrun commented Feb 3, 2023

>> uname -a
Linux jpambrun-rancher 3.10.0-1160.83.1.el7.x86_64 #1 SMP Wed Jan 25 16:41:43 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

>> curl -s https://i.jpillora.com/casey/just! | bash
Installing casey/just 1.13.0 (linux/amd64).....
######################################################################## 100.0%
mv with sudo...
Installed at /usr/local/bin/just

>> file /usr/local/bin/just
/usr/local/bin/just: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, BuildID[sha1]=5dd31aa9ff55b6b00d45dc70e07bac6d376f90f9, not stripped

Should have got x86_64, but got aarch64.

@jpambrun
Copy link
Contributor Author

jpambrun commented Feb 3, 2023

It's got the wrong asset for linux_amd64

        #choose from asset list
        URL=""
        FTYPE=""
        case "${OS}_${ARCH}" in
        "darwin_amd64")
                URL="https://github.com/casey/just/releases/download/1.13.0/just-1.13.0-aarch64-apple-darwin.tar.gz"
                FTYPE=".tar.gz"
                ;;
        "linux_amd64")
                URL="https://github.com/casey/just/releases/download/1.13.0/just-1.13.0-aarch64-unknown-linux-musl.tar.gz"
                FTYPE=".tar.gz"
                ;;
        "linux_arm")
                URL="https://github.com/casey/just/releases/download/1.13.0/just-1.13.0-armv7-unknown-linux-musleabihf.tar.gz"
                FTYPE=".tar.gz"
                ;;

@jpillora
Copy link
Owner

jpillora commented Feb 3, 2023

Ahh definitely a bug. it currently checks amd64 is go convention, then falls back to looking for 64 - hence this bug. installer needs to check convention too (x86_64)

PRs accepted :D

@jpillora jpillora added the bug label Feb 3, 2023
jpillora added a commit that referenced this issue Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants