NVM.fish — 2.0 🎏

[jorgebucaran]

NVM.fish completely rewritten using Fish 3.0, introducing a new CLI. Not a new CLI you need to learn. One that is familiar to you, if you've used the original NVM project, but without the cruft. Implements #122.

The usual suspects are included: install, use, remove uninstall, list, list-remote, and current.

NVM 2.0 presents a more consistent command-line interface (#81, #111), better XDG support (#108), and leverages modern Fish idioms for improved performance. Also fixed (#101, #112), so that switching versions only lasts for the lifetime of the current shell. Want to change that? There's a way too.

[thernstig]

I started from a validation perspective i.e. only commenting on the usage from the README.md perspective. I'll see if I have time to review the code later.

[thernstig]

I am happy with the commit 🥇 💯 👍

[jorgebucaran]

I think we're ready here. I won't be adding tests until Fishtape 3.0 is done. I'll probably land this tomorrow after going over the code one more time. If you want to try it out in the meantime, use:

fisher install jorgebucaran/nvm.fish@2.0

[thernstig]

I tested the new versions and found something. Is it expected? Without relaunching the shell, I tried e.g. nvm install <tab> and got:

nvm install <W> fish: An error occurred while redirecting file '/home/userA/.local/share/nvm/.index'
open: No such file or directory
<W> fish: An error occurred while redirecting file '/home/userA/.local/share/nvm/.index'
open: No such file or directory

Even if I specify a version manually and install I get another error. Is that expected? Relaunching the shell fixes it. I will try some functionality now when I have relaunched it.

[jorgebucaran]

I thought I had fixed that bug in da2cf70. Are you able to reproduce it? Thanks.

[thernstig]

A few things noticed.

1. Sometimes I get this, not sure why:

nvm install 12.18.4
curl: (23) Failed writing body (346 != 4220)
Installing Node v12.18.4 lts/erbium
Fetching https://nodejs.org/dist/v12.18.4/node-v12.18.4-linux-x64.tar.gz
Now using Node v12.18.4 (npm 6.14.6) ~/.local/share/nvm/v12.18.4/bin/node

2. If I install a version in one shell, and then open another, then I can properly do nvm list and it will show the installed version. But if I do nvm uninstall <version> it uninstalls it but exits with error code 1.

~> nvm list
   v12.18.4 lts/erbium
~> nvm current
~ [1]> nvm uninstall v12.18.4

~ [1]> nvm list
~ [1]>

This might actually also be the case where 1) is seen if I directly do a nvm install <version> after that. It installs it still though.

3. direnv (https://github.com/direnv/direnv/releases) does not work perfectly anymore with the layout "use node" but that is something I will write an issue on the that repo once this has been released.

[thernstig]

I thought I had fixed that bug in da2cf70. Are you able to reproduce it? Thanks.

Was that fix included in jorgebucaran/nvm.fish@2.0 which was what I installed and tested. I just tested it 30 mins ago and got that failure.

[jorgebucaran]

Was that fix included in jorgebucaran/nvm.fish@2.0 which was what I installed and tested.

Yes, everything I push to this branch is what you get when you install @2.0. I just fixed a few things. Please, remove the plugin and install it again. Normally you'd just fisher update ..., but this is a special case because NVM.fish is not released yet.

direnv (https://github.com/direnv/direnv/releases) does not work perfectly anymore with the layout "use node" but that is something I will write an issue on that repo once this has been released.

It shouldn't be too hard to support nvm install/use node, but I'd much prefer if I didn't have to.

curl: (23) Failed writing body (346 != 4220)

I'm not sure what's happening. From the two curl uses we have, that should be here:

nvm.fish/functions/nvm.fish

Lines 77 to 82 in 4517822

	if not command curl --progress-bar --location --show-error $url \
	| command tar --extract --gzip --directory $nvm_data/$ver 2>/dev/null
	command rm -rf $nvm_data/$ver
	echo -e "\033[F\33[2K\x1b[0mnvm: Invalid mirror or host unavailable: \"$url\"" >&2
	return 1
	end

I also found this on SO, but we're piping the output to tar, which I'd assume always reads the whole page. What else could it be? I noticed you're on Linux.

Could this be OS-specific? Do you happen to have a .curlrc file? What does it contain?

[thernstig]

I have no .curlrc file. I on Ubuntu 20.04. It did not happen every time, but sometimes. I agree it is quite strange. I will see if I can re-replicate this all soon, I unfortunately got a high-priority case to work with on my day-to-day job 😞

[jorgebucaran]

Did direnv put it there?

[jorgebucaran]

nvm puts it there, of course, when you install a version, and removes it when you uninstall it or use a different version (or switch to system if there's one). So, this could be a bug, but to be honest, I still don't understand what the issue you're having is.

Please provide me a longer dump of your terminal usage where the issue is clear.

[thernstig]

I was about to edit my reply. Yes, it sets it via the two env vars:

set -gx NODE_VERSIONS ~/.local/share/nvm
set -gx NODE_VERSION_PREFIX 'v'

See https://github.com/direnv/direnv/blob/f5b1566ab3f89c7e912ce0d1eb82ad8814247d30/stdlib.sh#L1068 calling https://github.com/direnv/direnv/blob/f5b1566ab3f89c7e912ce0d1eb82ad8814247d30/stdlib.sh#L625

[thernstig]

Still get it: curl: (23) Failed writing body (214 != 1891)

[jorgebucaran]

In that case, you did set it, albeit indirectly.

Okay, we can re-implement _nvm_current to play well with direnv.

Still get it: curl: (23) Failed writing body (214 != 1891)

Hmm.

[jorgebucaran]

@thernstig Last attempt using curl's --no-buffer flag. If this doesn't do it, I'll have to disable the progress bar, but that would be a shame. Or avoid the pipeline and redirect to a file, which wouldn't be so elegant. This is why we can't have nice things!

Please try again. 🙏

[thernstig]

In that case, you did set it, albeit indirectly.

Hmm.

Yes, to be fair, I did say I was about to edit my reply 😛

Please try again.

Maybe give wget a go? wget --show-progress --qO

I'd just redirect to a file to be done with it to keep the progress bar.

[jorgebucaran]

@thernstig Good news: the curl error should be fixed! 🙏

About direnv

I realized that letting direnv get away with just altering the PATH would miss the point of using nvm use, which is more than just switching versions. You'd lose the benefit of version validation and support for nvm_default_version. So, I decided to stick with nvm_current_version. Can direnv nvm use VERSION instead of altering PATH as you suggested?

For the record, this was my alternative _nvm_current implementation, just to show it's doable:

function _nvm_current
    set --local node (command --search node) || return
    string match --regex "^$nvm_data/v\d+\.\d+\.\d+" "" $node \
        | string replace --regex $nvm_data/ "" || echo system
end

[thernstig]

@thernstig Good news: the curl error should be fixed! 🙏

It is indeed fixed. You're awesome, great work! What was the exact problem?

About direnv

Can direnv nvm use VERSION instead of altering PATH as you suggested?

Yes, I think that might be more efficient and also less code for direnv. I'll write an issue once NVM 2.0 is released. I assume the only thing to figure out there in that project is to check if nvm.fish or nvm-sh is used and do an elif branch to instead just call nvm use when nvm.fish is used.

[jorgebucaran]

@thernstig Wouldn't it be better to use nvm use everywhere? I suppose the original nvm's nvm use does more than just juggling with the PATH, but I could be wrong. If and when you figure this out, I suggest using nvm use VERSION >/dev/null, since you might not care about the printout to stdout every time you open a new shell, but it's up to you.

[thernstig]

direnv handles a lot more than just nvm for me, and we use it as a shared tool to setup config for one project and when I juggle between project dirs I use it to not have to do any "use nvm" or other tools to setup the env for each project. That extra nvm use is a big annoyance stepping in/out of directories. This is what direnv solves so nicely.

Anyhow if we go back to this PR, it gets 5 thumbs up from me.

[jorgebucaran]

@thernstig Sorry, I was not referring to direnv. Let me clarify.

I was trying to say: wouldn't it better if direnv used nvm use to modify the PATH for both nvm.fish (like we already agreed to) and nvm-sh/nvm, because I suppose the original nvm's use command does more than just modify your PATH, e.g., translating aliases like "carbon" into v8.17.0, and so on.

That extra nvm use is a big annoyance stepping in/out of directories. This is what direnv solves so nicely.

Totally. 🙆‍♂️

[thernstig]

Ah, yes, great idea. I will see if I can do a nice write-up of an issue for direnv later.