Revisit $fish_user_paths usage

[jorgebucaran]

If nvm.fish tries to set -U fish_user_paths ... $fish_user_paths, the following error can occur if $fish_user_paths has global scope:

set: Universal variable 'fish_user_paths' is shadowed by the global variable of the same name.

See: #107

[nathan-gilbert]

I am getting this error

[jorgebucaran]

Just set the variable to universal scope for now.

[jackwestmoretab]

I think that a simple fix for this might be to change the offending line to: set fish_user_paths "$nvm_config/$ver/bin" $fish_user_paths

i.e., remove the -U setting. This simply appends "$nvm_config/$ver/bin" to whatever is in the user's fish_user_paths already. Works on my system.

[jorgebucaran]

@jackwestmoretab Yes, makes sense. 👍

[jackwestmoretab]

@jorgebucaran would you like me to make a Pull Request to this effect?

[jorgebucaran]

@jackwestmoretab Yes, go ahead, please! 💯

[jackwestmoretab]

@jorgebucaran #121

[arbourd]

Anyway to use this great implementation of nvm in the meantime? I only get errors even if I set it on my path manually.

My work around was change the script itself in functions.

[jorgebucaran]

@arbourd PR #123.

[jorgebucaran]

I just released 2.0. We're no longer using fish_user_paths. Installing or activating a version now changes the current shell only, for which we modify the PATH directly.

@arbourd @nathan-gilbert @jackwestmoretab @sh78 👋