updating adhoc metric filtering (apache#5105)

(cherry picked from commit cc0942a)
john-bodley · Jun 1, 2018 · 373c0fb · 373c0fb
1 parent b811851
commit 373c0fb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx b/superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx
@@ -211,8 +211,8 @@ describe('MetricsControl', () => {
 
       expect(!!wrapper.instance().selectFilterOption(
         {
-          metric_name: 'a_metric',
-          optionName: 'a_metric',
+          metric_name: 'avg__metric',
+          optionName: 'avg__metric',
           expression: 'AVG(metric)',
         },
         'a',
@@ -238,14 +238,27 @@ describe('MetricsControl', () => {
 
       expect(!!wrapper.instance().selectFilterOption(
         {
-          metric_name: 'a_metric',
-          optionName: 'a_metric',
+          metric_name: 'avg__metric',
+          optionName: 'avg__metric',
           expression: 'AVG(metric)',
         },
         'a',
       )).to.be.false;
     });
 
+    it('includes custom made simple saved metrics', () => {
+      const { wrapper } = setup();
+
+      expect(!!wrapper.instance().selectFilterOption(
+        {
+          metric_name: 'my_fancy_sum_metric',
+          optionName: 'my_fancy_sum_metric',
+          expression: 'SUM(value)',
+        },
+        'sum',
+      )).to.be.true;
+    });
+
     it('excludes auto generated metrics', () => {
       const { wrapper } = setup();
 

diff --git a/superset/assets/src/explore/components/controls/MetricsControl.jsx b/superset/assets/src/explore/components/controls/MetricsControl.jsx
@@ -13,7 +13,7 @@ import savedMetricType from '../../propTypes/savedMetricType';
 import adhocMetricType from '../../propTypes/adhocMetricType';
 import {
   AGGREGATES,
-  sqlaAutoGeneratedMetricRegex,
+  sqlaAutoGeneratedMetricNameRegex,
   druidAutoGeneratedMetricRegex,
 } from '../../constants';
 
@@ -210,7 +210,7 @@ export default class MetricsControl extends React.PureComponent {
     if (this.props.datasourceType === 'druid') {
       return druidAutoGeneratedMetricRegex.test(savedMetric.verbose_name);
     }
-    return sqlaAutoGeneratedMetricRegex.test(savedMetric.expression);
+    return sqlaAutoGeneratedMetricNameRegex.test(savedMetric.metric_name);
   }
 
   selectFilterOption(option, filterValue) {

diff --git a/superset/assets/src/explore/constants.js b/superset/assets/src/explore/constants.js
@@ -32,5 +32,6 @@ export const HAVING_OPERATORS = [
 ];
 export const MULTI_OPERATORS = [OPERATORS.in, OPERATORS['not in']];
 
+export const sqlaAutoGeneratedMetricNameRegex = /^(sum|min|max|avg|count|count_distinct)__.*$/i;
 export const sqlaAutoGeneratedMetricRegex = /^(LONG|DOUBLE|FLOAT)?(SUM|AVG|MAX|MIN|COUNT)\([A-Z0-9_."]*\)$/i;
 export const druidAutoGeneratedMetricRegex = /^(LONG|DOUBLE|FLOAT)?(SUM|MAX|MIN|COUNT)\([A-Z0-9_."]*\)$/i;