Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore][Adhoc Metrics] updating adhoc metric filtering #5105

Merged

Conversation

gabe-lyons
Copy link
Contributor

The adhoc metric control filters out all saved metrics that can be represented as simple adhoc metrics. However, at Airbnb some use cases have come up where people have wanted to use these simple saved metrics anyway so they can leverage consistent naming for these metrics across slices. As a result I have changed the filtering regex to look for metric_names like {aggregate}__{column}.

test plan:

  • open explore view with energy_usage datasource
  • verify the sum and average saved metrics do not appear
  • run specs

reviewers:
@john-bodley @michellethomas @graceguo-supercat @mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #5105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5105   +/-   ##
======================================
  Coverage    77.5%   77.5%           
======================================
  Files          44      44           
  Lines        8720    8720           
======================================
  Hits         6758    6758           
  Misses       1962    1962

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f611797...039c844. Read the comment docs.

@john-bodley john-bodley merged commit cc0942a into apache:master Jun 1, 2018
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Jun 1, 2018
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jun 1, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants