Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Observed in jenkinsci/bom#53 when attempting to add
workflow-multibranch
to the managed set. Running the Plugin Compatibility Tester againstworkflow-multibranch
plugin and a newer version ofworkflow-scm-step
, the following error appears:Evaluation
I saw that between
workflow-scm-step
2.6 and 2.7 atests
-classified JAR was removed, yetworkflow-multibranch
still depends on it.Solution
workflow-scm-step-2.6-tests.jar
contains nothing other than theSCMStepTest
class, andworkflow-multibranch
doesn't reference that class. The solution then is to remove the dependency onworkflow-scm-step-2.6-tests.jar
fromworkflow-multibranch
, allowing us to bumpworkflow-scm-step
past 2.6 fromworkflow-multibranch
's POM.Implementation
In this change I bump
workflow-scm-step
from 2.6 to 2.7 inworkflow-multibranch
's POM to cross this flag day.