Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow-multibranch-plugin #280

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add workflow-multibranch-plugin #280

merged 1 commit into from
Sep 30, 2020

Conversation

chriskilding
Copy link
Contributor

No description provided.

@chriskilding chriskilding mentioned this pull request Jul 21, 2020
Merged
jglick
jglick previously requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #277 first.

@jglick jglick added the enhancement New feature or request label Jul 21, 2020
timja
timja approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@timja timja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green build from master merge

@jglick jglick dismissed their stale review July 31, 2020 14:36

addressed

jglick
jglick previously requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong—not running PCT at all for the new plugin.

@jglick
Copy link
Member

jglick commented Jul 31, 2020

Working on it…

@jglick
Copy link
Member

jglick commented Jul 31, 2020

Fixed that, but now PCT is broken on the new plugin (which CI ought to now catch!):

Failed to execute goal on project workflow-multibranch: Could not resolve dependencies for project org.jenkins-ci.plugins.workflow:workflow-multibranch:hpi:2.21: Failure to find org.jenkins-ci.plugins.workflow:workflow-scm-step:jar:tests:2.11 in https://repo.jenkins-ci.org/public/ …

Seems that this is because jenkinsci/workflow-multibranch-plugin#86 from @basil was merged months ago, yet never released. @dwnusbaum / @bitwiseman / et al. can this be released please?

@dwnusbaum dwnusbaum mentioned this pull request Jul 31, 2020
Merged
dwnusbaum
dwnusbaum reviewed Aug 3, 2020
View reviewed changes
bom-latest/pom.xml Outdated Show resolved Hide resolved
@jetersen
Copy link
Member

jetersen commented Aug 4, 2020 •
edited
Loading

I'm confused by

bom/bom-latest/pom.xml

Line 20 in 81fa218

<workflow-support-plugin.version>3.5</workflow-support-plugin.version>

As these two test failed with workflow-support being version 3.4
pct-token-macro-2.235.x / testPluginActive – org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests
pct-junit-2.235.x / testPluginActive – org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests

- Update required: Pipeline: Supporting APIs (3.4) to be updated to 3.5 or higher
	at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:934)
	at hudson.PluginManager$2$1$1.run(PluginManager.java:548)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1131)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

pct-configuration-as-code-2.176.x failed because failFast 😓

@jglick
Copy link
Member

jglick commented Aug 5, 2020

Not sure offhand, would need to run the local-test.sh to see why.

@jglick jglick mentioned this pull request Aug 17, 2020
Merged
@chriskilding
Copy link
Contributor Author

rebuilding

@chriskilding chriskilding reopened this Sep 29, 2020
jetersen
jetersen approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jglick
jglick approved these changes Sep 29, 2020
View reviewed changes
sample-plugin/pom.xml Show resolved Hide resolved
oleg-nenashev
oleg-nenashev approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be a great addition to the BOM

@jetersen
Copy link
Member

Merging once build passes :)

@chriskilding
Copy link
Contributor Author

rebased, build passing :)

@jetersen jetersen merged commit 2a4b8ef into jenkinsci:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum left review comments

@jglick jglick jglick approved these changes

@jetersen jetersen jetersen approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chriskilding @jglick @jetersen @dwnusbaum @oleg-nenashev @timja