Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log output to console #5

Closed
wants to merge 2 commits into from

Conversation

chipironcin
Copy link
Contributor

Help to discern what is the regular expression and where is it looking for in the console output.

Help to discern what is the regular expression and where is it looking for in the console output.
@chipironcin
Copy link
Contributor Author

Currently, the regexp I want to check is Final result: UNSTABLE. Then:

Checking Final result: UNSTABLE

But the above might be confusing as it is not clear what is the regular expresion.
I propose changing it to:

Checking for 'Final result: UNSTABLE' in /home/user/ws/xxx/logs/*

@chipironcin
Copy link
Contributor Author

Any admin around here?

@basil
Copy link
Member

basil commented Jun 15, 2018

I recently started maintaining this plugin and am starting to go through the PR backlog. This change looks good overall! There is only one more thing I'd like to see before merging this PR: rebasing the PR against the latest code in master and getting the newly-added tests (from #12) to pass against this change. The current change will break the tests, as the tests depend on the current console log format. It should be trivial to update the tests to work with the new console log format from this change. Once the code is rebased and the tests are updated with the new console log format, I'll be happy to merge this!

@chipironcin
Copy link
Contributor Author

Will do soon. Thanks @basil

@chipironcin
Copy link
Contributor Author

I performed the changes in the master branch of my repository which lead to some technical issues.
Dismissing this PR in favor of #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants