Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log output to console #17

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

chipironcin
Copy link
Contributor

This change improves what the plugin logs to the console to it is easier for the user to identify what the plugin is looking for and where.

Updated the tests

@chipironcin
Copy link
Contributor Author

@basil
What is the best way of launching the tests for this locally?
Can you re run tests in Jenkins? I cannot tell from the logs if they are failing because of my changes or because something else.

@basil
Copy link
Member

basil commented Jun 18, 2018

Looks like your automated test run had an infrastructure-related issue in the windows-2.121.1 branch, which then caused the other branches to be interrupted before the tests could run. I surmise this failure wouldn't happen if you ran the tests again a bit later. If it does, I can investigate further and possibly file an INFRA bug.

To run the tests locally, you can use mvn clean install (which is essentially what the CI system does). You can also run the tests from within IntelliJ or any other IDE with a JUnit runner.

@chipironcin
Copy link
Contributor Author

It passes locally for me:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running InjectedTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.521 s - in InjectedTest
[INFO] Running hudson.plugins.textfinder.TextFinderPublisherAgentTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.295 s - in hudson.plugins.textfinder.TextFinderPublisherAgentTest
[INFO] Running hudson.plugins.textfinder.TextFinderPublisherFreestyleTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.705 s - in hudson.plugins.textfinder.TextFinderPublisherFreestyleTest
[INFO] Running hudson.plugins.textfinder.TextFinderPublisherPipelineTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.213 s - in hudson.plugins.textfinder.TextFinderPublisherPipelineTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0

Can we rerun?

@basil basil merged commit 16a05c9 into jenkinsci:master Jul 4, 2018
basil added a commit that referenced this pull request Jul 4, 2018
@basil
Copy link
Member

basil commented Jul 4, 2018

I merged this change after seeing that the tests passed locally for you, but once I did so the build started failing. Therefore, I've reverted the change. Can you please rebase against the latest master branch and submit a new pull request? Then we can work on getting the build working and the tests passing.

@chipironcin
Copy link
Contributor Author

#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants