Add support for a Jenkins version argument (CLI and env var) + Make Jenkins WAR parameter optional in the Plugin Manager Lib API and the implementation #232
Conversation
| if (jenkinsVersion != null) { | ||
| return jenkinsVersion; | ||
| } | ||
| if (jenkinsWarFile != null) { |
There was a problem hiding this comment.
what do you think about moving this to the CLI? so the lib only works with a resolved jenkins version?
There was a problem hiding this comment.
I do not think that Jenkins version is always needed for the library's logic. OTOH we could be more opinionated there
oleg-nenashev
changed the title
oleg-nenashev
changed the title
|
Is it good to go now @timja, maybe towards 2.3.0? |
|
go for it. |
|
Hello, @timja @oleg-nenashev the latest LTS release of Jenkins i.e. 2.263.4 still got v2.2.0 of plugin-installation-manager-tool. This is from the docker file - ARG PLUGIN_CLI_URL=https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/2.2.0/jenkins-plugin-manager-2.2.0.jar |
|
create a new issue next time, it's being updated in jenkinsci/docker#1073 |
This PR adds two enhancements which allow Plugin Installation Manager to check plugin version compatibility when no Jenkins WAR supplied. It addresses use-cases like the jenkinsfile Runner of in #193 (comment) and jenkinsci/jenkinsfile-runner#423
CC @timja @bericoberin