Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim for install-plugins -> plugin-installation-manager-tool #1073

Closed
wants to merge 3 commits into from
Closed

Shim for install-plugins -> plugin-installation-manager-tool #1073

wants to merge 3 commits into from

Conversation

slide
Copy link
Member

@slide slide commented Jan 29, 2021

This replaces the contents of install-plugins.sh to use plugin-manager-installation-tool internally. Requires an update to plugin-installation-manager-tool 2.5.0 (#1071 does this as well).

@slide slide requested a review from a team as a code owner January 29, 2021 15:20
@slide
Copy link
Member Author

slide commented Mar 18, 2021

Do we want to expose the options for proxy stuff via environment variables?

@slide
Copy link
Member Author

slide commented May 17, 2021

Is this ok to merge? Any items that people want to see?

@oleg-nenashev @MarkEWaite

@oleg-nenashev oleg-nenashev self-requested a review May 17, 2021 23:21
@MarkEWaite
Copy link
Contributor

Is this ok to merge? Any items that people want to see?

@oleg-nenashev @MarkEWaite

Y.R. Sudhakar has proposed a first draft of a plugin installation manager section for the "Managing Plugins" page of the Jenkins Handbook on https://www.jenkins.io. I'd prefer that we have that documentation available and a blog post to announce the change before this is merged.

@ianwilliams1
Copy link

Should updating the README - Usage section be included as part of this change or is a issue required?

@slide
Copy link
Member Author

slide commented Aug 24, 2021

I don't know if this will be merged or not, so whatever others decide.

@dduportal
Copy link
Contributor

Hello there ! What is the status of this one? That would be really useful but might need a check during the paltform SIG meeting as it might impact end users (but for their own good).

@timja
Copy link
Member

timja commented May 27, 2022

Should be fine once conflicts are resolved I think

@dduportal
Copy link
Contributor

Should be fine once conflicts are resolved I think

Shouldn't we communicate on this as it might slightly change end users build behaviors?

@timja
Copy link
Member

timja commented May 27, 2022

Should be fine once conflicts are resolved I think

Shouldn't we communicate on this as it might slightly change end users build behaviors?

could do, do you mean in the README or something else?

@timja timja mentioned this pull request Jun 25, 2022
@timja
Copy link
Member

timja commented Jun 25, 2022

Alternative: #1408

@timja timja closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants