-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of Reflections in PluginCompatTesterHooks
#481
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,15 +90,9 @@ | |
<version>1.11</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.reflections</groupId> | ||
<artifactId>reflections</artifactId> | ||
<version>0.10.2</version> | ||
<exclusions> | ||
<exclusion> | ||
<groupId>com.google.code.findbugs</groupId> | ||
<artifactId>jsr305</artifactId> | ||
</exclusion> | ||
</exclusions> | ||
<groupId>org.kohsuke.metainf-services</groupId> | ||
<artifactId>metainf-services</artifactId> | ||
<version>1.9</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.slf4j</groupId> | ||
|
@@ -192,23 +186,6 @@ | |
</execution> | ||
</executions> | ||
</plugin> | ||
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> | ||
<artifactId>maven-compiler-plugin</artifactId> | ||
<!-- Version specified in parent POM --> | ||
<configuration> | ||
<annotationProcessorPaths> | ||
<path> | ||
<groupId>info.picocli</groupId> | ||
<artifactId>picocli-codegen</artifactId> | ||
<version>${picocli.version}</version> | ||
</path> | ||
</annotationProcessorPaths> | ||
<compilerArgs> | ||
<arg>-Aproject=${project.groupId}/${project.artifactId}</arg> | ||
</compilerArgs> | ||
</configuration> | ||
</plugin> | ||
Comment on lines
-195
to
-211
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was interfering with the registration of the |
||
<plugin> | ||
<groupId>org.jenkins-ci.tools</groupId> | ||
<artifactId>maven-hpi-plugin</artifactId> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,15 +130,6 @@ public class PluginCompatTesterCli implements Callable<Integer> { | |
"Comma-separated list of arguments to pass to Maven (like -Pxxx; not to be confused with Java arguments or Maven properties). These arguments will be passed to Maven both during compilation and when running tests.") | ||
private List<String> mavenArgs; | ||
|
||
@CheckForNull | ||
@CommandLine.Option( | ||
names = "--hook-prefixes", | ||
split = ",", | ||
arity = "1", | ||
paramLabel = "prefix", | ||
description = "Comma-separated list of prefixes of extra hook classes.") | ||
private List<String> hookPrefixes; | ||
|
||
Comment on lines
-133
to
-141
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No longer makes sense now that an annotation is the explicit way to opt in. |
||
@CheckForNull | ||
@CommandLine.Option( | ||
names = "--external-hooks-jars", | ||
|
@@ -189,9 +180,6 @@ public Integer call() throws PluginCompatibilityTesterException { | |
if (mavenArgs != null) { | ||
config.setMavenArgs(mavenArgs); | ||
} | ||
if (hookPrefixes != null) { | ||
config.setHookPrefixes(hookPrefixes); | ||
} | ||
if (externalHooksJars != null) { | ||
config.setExternalHooksJars(externalHooksJars); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to create the
META-INF/services
entries for these hooks to be loadable viaServiceLoader
.