Get rid of Reflections in PluginCompatTesterHooks
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Mar 1, 2023
Comment on lines
+93
to
+95
| <groupId>org.kohsuke.metainf-services</groupId> | ||
| <artifactId>metainf-services</artifactId> | ||
| <version>1.9</version> |
There was a problem hiding this comment.
Needed to create the META-INF/services entries for these hooks to be loadable via ServiceLoader.
Comment on lines
-195
to
-211
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <!-- Version specified in parent POM --> | ||
| <configuration> | ||
| <annotationProcessorPaths> | ||
| <path> | ||
| <groupId>info.picocli</groupId> | ||
| <artifactId>picocli-codegen</artifactId> | ||
| <version>${picocli.version}</version> | ||
| </path> | ||
| </annotationProcessorPaths> | ||
| <compilerArgs> | ||
| <arg>-Aproject=${project.groupId}/${project.artifactId}</arg> | ||
| </compilerArgs> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
This was interfering with the registration of the metainf-services annotation processor. Since it was optional, I opted to dispense with it rather than debug it.
Comment on lines
-133
to
-141
| @CheckForNull | ||
| @CommandLine.Option( | ||
| names = "--hook-prefixes", | ||
| split = ",", | ||
| arity = "1", | ||
| paramLabel = "prefix", | ||
| description = "Comma-separated list of prefixes of extra hook classes.") | ||
| private List<String> hookPrefixes; | ||
|
|
There was a problem hiding this comment.
No longer makes sense now that an annotation is the explicit way to opt in.
jtnord
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394 by dropping the dependency on Reflections in favor of
ServiceLoader. This requires each hook to be annotated with@MetaInfServices(PluginCompatTesterHookBeforeCheckout.class),@MetaInfServices(PluginCompatTesterHookBeforeCompile.class), or@MetaInfServices(PluginCompatTesterHookBeforeExecution.class)and obviates the need for a--hook-prefixesoption. To test this I verified in the debugger that the same hooks got loaded as before this PR (in the same order).