matching test-harness when casc is added #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this superseded by jenkinsci/bom#315? |
looks like not: |
|
Tested this in jenkinsci/bom#294 and it works... |
|
Please merge with master @joseblas. |
timja
reviewed
Oct 19, 2020
| @@ -379,11 +381,11 @@ public PluginCompatReport testPlugins() | |||
| } | |||
|
|
|||
| if (failed && config.isFailOnError()) { | |||
| throw new AbortException("Execution was aborted due to the failure in a plugin test (-failOnError is set)"); | |||
| throw new AbortException("Execution was aborted due to the failure in a plugin test (-failOnError is set)"); | |||
There was a problem hiding this comment.
unnecessary whitespace change, and adds tabs to a file that uses spaces
| } | ||
|
|
||
| return report; | ||
| } | ||
| } |
There was a problem hiding this comment.
unnecessary whitespace change, and adds tabs to a file that uses spaces
| @@ -432,7 +434,7 @@ private TestExecutionResult testPluginAgainst(MavenCoordinates coreCoordinates, | |||
|
|
|||
| File pluginCheckoutDir = new File(config.workDirectory.getAbsolutePath() + File.separator + plugin.name + File.separator); | |||
|
|
|||
| try { | |||
| try { | |||
There was a problem hiding this comment.
unnecessary whitespace change, and adds tabs to a file that uses spaces
|
@joseblas why was this closed? we're relying on it in bom |
|
If we are consuming it, it needs to remain open. |
This was referenced Mar 10, 2021
|
Replaced by #276. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.