Use warnings-ng instead of deprecated findbugs #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmunozm
approved these changes
Oct 1, 2020
|
I have removed the |
|
Failure caused by infra issue
Closing and reopening later |
raul-arabaolaza
changed the title
oleg-nenashev
previously requested changes
Oct 2, 2020
There was a problem hiding this comment.
Please use a single command to avoid performance overheads. Example: https://github.com/jenkinsci/custom-war-packager/blob/master/Jenkinsfile#L46-L49
Requested by Oleg, makes perfect sense
|
I made a mistake, ok, I need to give a bit of extra work here, please do not merge, is not ready yet |
|
@raul-arabaolaza what's wrong with this? it seems fine |
bmunozm
approved these changes
Oct 19, 2020
jglick
approved these changes
Oct 19, 2020
|
Can this please be merged so that #261 can be deployed and I can fix up jenkinsci/bom@7322eb7? |
|
Sorry, my fault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates #259 per @bmunozm request so it can be tested by the PR Builder, I have already review the changes and look safe to run