do not rely on long deprecated FileOnMasterKeyStoreSource #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
Jun 21, 2024
There was a problem hiding this comment.
dwnusbaum
approved these changes
Jun 21, 2024
dwnusbaum
approved these changes
Jul 1, 2024
Merged
6 tasks
jtnord
added a commit
to jtnord/pipeline-model-definition-plugin
that referenced
this pull request
Jul 8, 2024
amends jenkinsci#723 that was working as the KeyStore was not validated. However jenkinsci/credentials-plugin#543 now validates the keystore and hence this test started failing as the password did not match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileOnMasterKeyStoreSourcewas deprecated 5 years ago, this replaces it with a non deprecated way of defining a credential.Adapt to jenkinsci/credentials-plugin#540 by not using code about to be removed
testing done: relying on the test to pass which is testing the test itself.